-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #3024 and #3030 Series-Analysis GRAD #3036
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
2fa3b26
Per #3024, roll the version number from 12.0 to 12.1 prior to adding …
JohnHalleyGotway cad8be5
Merge remote-tracking branch 'origin/develop' into feature_3024_GRAD
JohnHalleyGotway 28091e3
Per #3024, return bad data for the square root of a negative number
JohnHalleyGotway a6f7213
Per #3024, update Grid-Stat to write 4 new columns to the GRAD line t…
JohnHalleyGotway 32591e0
Merge remote-tracking branch 'origin/develop' into feature_3024_GRAD
JohnHalleyGotway a7e4aa8
Per #3024, tweak laplace MSE computation
JohnHalleyGotway 5c80fda
Per #3024, add appendixC.rst equations for the new statistics
JohnHalleyGotway b7f13d4
Per #3024, escape embedded underscores in equations only for latex fo…
JohnHalleyGotway 6f1f6e8
Per #3024, add reference to paper and summary of the new gradient stats
JohnHalleyGotway 3849033
Merge remote-tracking branch 'origin/develop' into feature_3030_serie…
JohnHalleyGotway 23fc4ad
Per #3030, update docs by moving the gradient config entry from Grid-…
JohnHalleyGotway c7a1582
Per #3030, update Series-Analysis config file by adding the gradient …
JohnHalleyGotway 6dce6f2
Per #3030, add descriptions of GRAD statistics for inclusion in the l…
JohnHalleyGotway 7ebbb95
Per #3030, add the GRADInfo::get_stat() member function to be called …
JohnHalleyGotway 6f71ba2
Per #3030, fix parsing logic for the gradient dictionary.
JohnHalleyGotway 258d1a1
Per #3030, add gradient entries to existing Series-Analysis config files
JohnHalleyGotway e54eb54
Per #3030, add GRADInfo::set_stat() member function
JohnHalleyGotway 9d876c4
Per #3030, enhance Series-Analysis to aggregate the GRAD line type in…
JohnHalleyGotway 0a0beb6
Per #3030, reduce the volume of SonarQube code smells.
7b25cb5
Updated syntax
j-opatz 92ec11a
Updated syntax
j-opatz 82ce8e3
Updated syntax
j-opatz 6c52891
Merge remote-tracking branch 'origin/develop' into feature_3030_serie…
JohnHalleyGotway eaec8ec
Merge branch 'develop' into feature_3030_series_analysis_GRAD
JohnHalleyGotway File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this fits under "unpublished material" type. If so, that would mean it can be mentioned in-line with I. Ebert-Uphoff (2024, unpublished article) and is not included in the reference page.
However, if this is expected to be accepted soon, then I'd rather we just stick to a normal journal article citation (similar to how it currently is written) rather than trying to remember the name of the article later on.