-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 313 consistent headers #316
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing the heading formatting to match sphinx and METplus User's Guide documentation.
Changing the heading formatting to match sphinx and METplus User's Guide documentation.
Changing the heading formatting to match sphinx and METplus User's Guide documentation. Left bolded sections alone. Are these sub-subsections?
…feature_313_consistent_headers
…313_consistent_headers
…METcalcpy into feature_313_consistent_headers
…313_consistent_headers
7 tasks
jprestop
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the changes and approve this request. Thank you for all of your work on this @lisagoodrich.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
All of the chapters, sections and sub-sections are consistent across the different chapters. METcalcpy/docs/index.rst and METcalcpy/docs/Users_Guide/index.rst files have been updated to include ### for the title. Please note, there are no chapter sections in the index files. It will mess up the Table of Contents formatting in the left side menu window.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Please confirm all of the chapter, section and sub-section changes are accurate. Here is the feature branch web page: https://metcalcpy.readthedocs.io/en/feature_313_consistent_headers/Contributors_Guide/index.html
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes] there are no errors in the build code.
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [7/21/23].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes