Feature 378 add ctp hi diagnostics #394
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alc_ctp()`) and Humidity Index (`calc_humidity_index()`).
…sts max_prs_diff to be 100 hPa by default, and cleans up print statements.
…e-worked to take a full Xarray object for NWP data, which mainly involved making `station_index` a positional rather than a kwarg. Added new `station_name` kwarg if needed for calc_ctp optional plotting. Avoids unnecessary interpolation of pressure when a specific pressure is requested because the user provided it so we don't need to interpolate. Similarly, the bottom/top pressures are also known in this case and don't need to be interpolated, only the data used at those pressures. Changes to debugging statements, bounds checking to see if the starting and top/bottom pressures are more than a certain pressure delta away from the values requested. Buildout of calc_humidity_index to be more like calc_ctp in many regards.
… after finishing the calc_humidity_index function development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #378.
Describe testing already performed for these changes:
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Do these changes include sufficient testing updates? [Yes or No]
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [Yes or No]
If yes, please describe:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METcalcpy-X.Y.Z Development project for official releases