Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Truth: For dtcenter/MET#3008 #2811

Closed
8 of 11 tasks
JohnHalleyGotway opened this issue Dec 3, 2024 · 1 comment · Fixed by #2812
Closed
8 of 11 tasks

Update Truth: For dtcenter/MET#3008 #2811

JohnHalleyGotway opened this issue Dec 3, 2024 · 1 comment · Fixed by #2812
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: CI/CD Continuous integration and deployment issues priority: blocker Blocker requestor: METplus Team METplus Development Team type: update truth Update truth dataset
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Dec 3, 2024

Describe Expected Changes

Adds a units attribute to the NetCDF output from Gen-Vx-Mask, and in many cases, units = flag. This has led to a change in the OBS_UNITS column for at least one of the METplus use cases. Rather than being set to NA, it now contains flag. This change does make sense. When MET reads NetCDF inputs, it does check for, store, and write to the output the value of the units variable attribute.

Define the Metadata

Title

  • Define the Title of this issue as Update Truth: For dtcenter/{REPO}#{PR_NUMBER} to indicate the repository and pull request that warranted this issue.

Assignee

Assign this issue to the author of the pull request that warranted this issue. Optionally assign anyone else who should review the differences in the output.

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Milestone and Projects

  • Select Milestone as the next official version if updating truth data for the develop branch OR select next METplus-Wrappers-X.Y.Z bugfix version if updating truth data for a main_vX.Y branch.
  • If updating truth data for the develop branch, select the METplus-Wrappers-X.Y.Z Development project OR if updating truth for a main_vX.Y branch, select the Coordinated METplus-X.Y Support project

Update Truth Checklist

  • Review the GitHub Actions workflow that was triggered by the PR merge
    • If no differences were found, note this in a comment.
    • If all of the differences are expected, note this in a comment.
      Include any details of how the review was performed.
    • If unexpected differences are found, the following instructions can
      help uncover potential explanations. If none of these apply and the
      source of the differences cannot be determined, contact the
      METplus wrappers lead engineer (@georgemccabe) for assistance.
      • Search for other open issues that have the label type: update truth
        applied by clicking on the label on this issue. Coordinate with the
        author of these issues to ensure all diffs are properly reviewed.
      • Check if any additional GitHub Actions testing workflows have been
        triggered since the workflow that corresponds to this issue was run.
        Review the latest run to ensure that there are no diffs that are
        unrelated to this issue.
      • If the incorrect differences are caused by the changes from the
        issue that warranted this issue, consider reverting the PR and
        re-opening the issue.
    • Iterate until one of the above conditions apply.
  • Approve the update of the truth data
    • Contact the METplus wrappers lead engineer (@georgemccabe) or
      backup lead (@jprestop) to let them know that the truth data can
      be updated.
  • Update the truth data.
    This should be handled by a METplus wrappers engineer.
    See the instructions to update the truth data
    for more info.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added priority: blocker Blocker alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: CI/CD Continuous integration and deployment issues requestor: METplus Team METplus Development Team type: update truth Update truth dataset labels Dec 3, 2024
@JohnHalleyGotway JohnHalleyGotway added this to the METplus-6.1.0 milestone Dec 3, 2024
@JohnHalleyGotway JohnHalleyGotway self-assigned this Dec 3, 2024
@JohnHalleyGotway JohnHalleyGotway moved this from 🩺 Needs Triage to 🏗 In progress in METplus-Wrappers-6.1.0 Development Dec 3, 2024
@JohnHalleyGotway
Copy link
Collaborator Author

JohnHalleyGotway commented Dec 3, 2024

This METplus GHA testing workflow run was triggered by this MET commit. Differences were flagged Grid-Stat output from this fire use case. The diffs are limited to the OBS_UNITS column changing from NA to flag.

This difference is consistent with the changes made to the Gen-Vx-Mask code.

The METplus truth data for the develop branch can be safely updated.

@JohnHalleyGotway JohnHalleyGotway linked a pull request Dec 3, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from 🏗 In progress to 🏁 Done in METplus-Wrappers-6.1.0 Development Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: CI/CD Continuous integration and deployment issues priority: blocker Blocker requestor: METplus Team METplus Development Team type: update truth Update truth dataset
Projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

1 participant