Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit: PR114689 #1607

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

pre-commit: PR114689 #1607

wants to merge 2 commits into from

Conversation

dtcxzyw
Copy link
Owner

@dtcxzyw dtcxzyw commented Nov 3, 2024

@github-actions github-actions bot mentioned this pull request Nov 3, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2024

runner: buildkitsandbox
baseline runner: cseadmin-PowerEdge-R830
baseline: llvm/llvm-project@25af8f5
patch: llvm/llvm-project#114689
sha256: 0612cf07c57efb2a7df74e9ebc1ebba3ba0bd7baa4eb761cfb9ab7ffc02f692c
commit: d759735
1972 files changed, 368723 insertions(+), 370390 deletions(-)

Compilation time result (by files):
Top 5 improvements:
  abc/mvcContain.c.ll 118170528 -> 113278082 -4.14%
  llvm/TargetParser.cpp.ll 546537375 -> 527744279 -3.44%
  rocksdb/db_dump_tool.cc.ll 488142456 -> 481646389 -1.33%
  flac/iconvert.c.ll 117387265 -> 115900355 -1.27%
  libwebp/img2webp.c.ll 189576858 -> 187215286 -1.25%
Top 5 regressions:
  darktable/MrwDecoder.cpp.ll 284265870 -> 295222237 +3.85%
  php/php_http_parser.ll 717123623 -> 741040919 +3.34%
  libquic/prtime.cc.ll 625163244 -> 645010533 +3.17%
  linux/intel_hotplug.ll 260402343 -> 268500067 +3.11%
  minetest/map.cpp.ll 1941943301 -> 1998303595 +2.90%

Overall: -0.00474826%

Compilation time result (by projects):
Top 5 improvements:
  libsodium 25145958012 -> 25083825921 -0.25%
  simdjson 7545750743 -> 7532799497 -0.17%
  softposit-rs 6589900268 -> 6582259414 -0.12%
Top 5 regressions:
  coremark 704938141 -> 706913413 +0.28%
  msdfgen 13438028220 -> 13474182009 +0.27%
  zfp 20388897097 -> 20430464460 +0.20%
  rustfmt-rs 163020450297 -> 163308240700 +0.18%
  hermes 402833277727 -> 403347784279 +0.13%

Overall: -0.00054596%

Improvements:
  indvars.NumSimplifiedSRem 31 -> 33 +6.45%
  correlated-value-propagation.NumCmps 240115 -> 241671 +0.65%
  sccp.NumInstRemoved 1913503 -> 1922837 +0.49%
  loop-simplify.NumNested 11290 -> 11322 +0.28%
  indvars.NumFoldedUser 1843 -> 1846 +0.16%
  correlated-value-propagation.NumSaturating 1427 -> 1429 +0.14%
  correlated-value-propagation.NumShlNSW 98181 -> 98268 +0.09%
  correlated-value-propagation.NumShlNW 221889 -> 222064 +0.08%
  correlated-value-propagation.NumShlNUW 123708 -> 123796 +0.07%
  indvars.NumElimCmp 46414 -> 46447 +0.07%
Regressions:
  indvars.NumElimIdentity 1818 -> 1718 -5.50%
  bdce.NumSimplified 6266 -> 6198 -1.09%
  instcombine.NumFactor 41081 -> 40954 -0.31%
  aggressive-instcombine.NumInstrsReduced 61742 -> 61601 -0.23%
  constraint-elimination.NumCondsRemoved 1471507 -> 1469343 -0.15%
  bdce.NumSExt2ZExt 4745 -> 4742 -0.06%
  correlated-value-propagation.NumSDivSRemsNarrowed 2336 -> 2335 -0.04%
  correlated-value-propagation.NumSMinMax 4969 -> 4967 -0.04%
  loop-instsimplify.NumSimplified 193124 -> 193051 -0.04%
  loop-simplifycfg.NumLoopExitsDeleted 6128 -> 6126 -0.03%

d759735 pre-commit: Update
12 9 bench/abc/optimized/cecSat.c.ll
16 13 bench/abc/optimized/cecSatG3.c.ll
31 32 bench/abc/optimized/giaResub2.c.ll
5 2 bench/abc/optimized/giaStr.c.ll
92 94 bench/abseil-cpp/optimized/charconv_bigint.cc.ll
21 35 bench/assimp/optimized/glTF2Exporter.cpp.ll
20 32 bench/assimp/optimized/glTFExporter.cpp.ll
18 30 bench/assimp/optimized/glTFImporter.cpp.ll
2 9 bench/assimp/optimized/sweep_context.cc.ll
3 4 bench/c3c/optimized/parse_global.c.ll
4 9 bench/casadi/optimized/cvodes.c.ll
3 8 bench/casadi/optimized/idas.c.ll
1 2 bench/clamav/optimized/clamsubmit.c.ll
22 30 bench/clamav/optimized/egg.c.ll
37 36 bench/clamav/optimized/jpeg.c.ll
14 16 bench/clap-rs/optimized/5651dp9k16h53y8x.ll
15 13 bench/cmake/optimized/cmCustomCommandGenerator.cxx.ll
27 26 bench/cmake/optimized/cmDyndepCollation.cxx.ll
8 12 bench/cmake/optimized/cmLocalGenerator.cxx.ll
6 10 bench/cpython/optimized/_ssl.ll
26 35 bench/cpython/optimized/posixmodule.ll
26 46 bench/cpython/optimized/xmltok.ll
27 25 bench/csmith/optimized/CGContext.cpp.ll
2 4 bench/curl/optimized/libcurl_la-hsts.ll
12 16 bench/cvc5/optimized/theory_strings_utils.cpp.ll
49 40 bench/darktable/optimized/MrwDecoder.cpp.ll
58 59 bench/darktable/optimized/export.c.ll
47 49 bench/darktable/optimized/introspection_lut3d.c.ll
23 24 bench/delta-rs/optimized/4say4x9grcidoih4.ll
46 48 bench/duckdb/optimized/ub_duckdb_optimizer.cpp.ll
30 32 bench/duckdb/optimized/ub_duckdb_optimizer_rules.cpp.ll
12 40 bench/eastl/optimized/TestDeque.cpp.ll
18 42 bench/eastl/optimized/TestFixedMap.cpp.ll
12 54 bench/eastl/optimized/TestSet.cpp.ll
13 17 bench/flac/optimized/iconvert.c.ll
6 7 bench/flac/optimized/stream_encoder.c.ll
8 7 bench/flatbuffers/optimized/idl_gen_rust.cpp.ll
16 14 bench/flatbuffers/optimized/idl_gen_ts.cpp.ll
4 6 bench/fmt/optimized/compile-test.cc.ll
2 3 bench/fmt/optimized/std-test.cc.ll
6 9 bench/fmt/optimized/xchar-test.cc.ll
1 5 bench/folly/optimized/DeterministicSchedule.cpp.ll
8 24 bench/folly/optimized/EDFThreadPoolExecutor.cpp.ll
7 8 bench/folly/optimized/FunctionScheduler.cpp.ll
16 28 bench/folly/optimized/HeapTimekeeper.cpp.ll
47 50 bench/freetype/optimized/ftbase.c.ll
53 54 bench/g2o/optimized/hyper_graph.cpp.ll
47 46 bench/git/optimized/cache-tree.ll
51 58 bench/git/optimized/grep.ll
52 53 bench/graphviz/optimized/lu.c.ll
10 14 bench/graphviz/optimized/xlayout.c.ll
70 69 bench/gromacs/optimized/dlarrex.cpp.ll
4 12 bench/hermes/optimized/TargetParser.cpp.ll
3 10 bench/hermes/optimized/UniquingStringLiteralTable.cpp.ll
6 13 bench/hyperscan/optimized/accel_dfa_build_strat.cpp.ll
10 8 bench/hyperscan/optimized/ng_calc_components.cpp.ll
15 14 bench/hyperscan/optimized/rose_build_role_aliasing.cpp.ll
3 5 bench/icu/optimized/ustrcase.ll
38 36 bench/jsonnet/optimized/vm.cpp.ll
24 38 bench/libquic/optimized/ssl_cipher.c.ll
42 44 bench/libquic/optimized/url_canon_mailtourl.cc.ll
40 42 bench/libquic/optimized/url_canon_pathurl.cc.ll
1 4 bench/llvm/optimized/SemaCast.cpp.ll
68 69 bench/meilisearch-rs/optimized/3f4k2xees4fvt0r.ll
11 12 bench/minetest/optimized/profilergraph.cpp.ll
18 19 bench/minetest/optimized/sound_manager.cpp.ll
31 33 bench/msdfgen/optimized/main.cpp.ll
29 30 bench/nix/optimized/derivations.ll
5 9 bench/node/optimized/libnode.crypto_common.ll
2 5 bench/nori/optimized/bitmap.cpp.ll
67 72 bench/nuttx/optimized/lib_fopen.c.ll
72 68 bench/nuttx/optimized/sched_mergeprioritized.c.ll
55 59 bench/oiio/optimized/environment.cpp.ll
6 3 bench/opencv/optimized/hybrid_binarizer.cpp.ll
30 37 bench/opencv/optimized/pose_graph.cpp.ll
18 17 bench/opencv/optimized/tf_importer.cpp.ll
33 37 bench/openjdk/optimized/threadService.ll
17 21 bench/openspiel/optimized/hex.cc.ll
21 28 bench/openssl/optimized/libssl-lib-ssl_lib.ll
17 16 bench/openusd/optimized/clipSetDefinition.cpp.ll
40 46 bench/openusd/optimized/read.c.ll
8 4 bench/openusd/optimized/stbImage.cpp.ll
10 6 bench/pbrt-v4/optimized/stbimage.cpp.ll
29 31 bench/php/optimized/zend_compile.ll
28 32 bench/postgres/optimized/fe-misc.ll
12 14 bench/postgres/optimized/spell.ll
17 19 bench/protobuf/optimized/printer.cc.ll
60 61 bench/qdrant-rs/optimized/1qtu8dw3f0ctj9yc.ll
8 9 bench/qemu/optimized/block_vhdx-log.c.ll
15 16 bench/qemu/optimized/hw_ufs_lu.c.ll
7 9 bench/qemu/optimized/util_async.c.ll
11 10 bench/raylib/optimized/raudio.c.ll
42 43 bench/re2/optimized/parse.cc.ll
7 11 bench/recastnavigation/optimized/NavMeshPruneTool.cpp.ll
4 5 bench/redis/optimized/defrag.ll
5 6 bench/ruby/optimized/compile.ll
12 13 bench/rust-analyzer-rs/optimized/10elsj6wik4dx3zk.ll
59 60 bench/rust-analyzer-rs/optimized/3xzp7fojhwn2ktpr.ll
11 7 bench/stb/optimized/stb_image.c.ll
50 79 bench/stb/optimized/stb_rect_pack.c.ll
9 8 bench/stb/optimized/stb_vorbis.c.ll
19 18 bench/vcpkg/optimized/dependencies.cpp.ll
6 14 bench/velox/optimized/LeadLag.cpp.ll
26 27 bench/verilator/optimized/V3Descope.cpp.ll
18 11 bench/wireshark/optimized/packet-gcsna.c.ll
48 52 bench/wireshark/optimized/packet-thrift.c.ll
4 8 bench/wireshark/optimized/sequence_diagram.cpp.ll
3 7 bench/wolfssl/optimized/benchmark.c.ll
1 3 bench/wolfssl/optimized/sp_int.c.ll
93 95 bench/xgboost/optimized/auc.cc.ll
46 50 bench/yalantinglibs/optimized/conformance_test_runner.cc.ll
35 39 bench/yosys/optimized/liberty.ll
13 12 bench/yosys/optimized/show.ll
32 31 bench/yosys/optimized/submod.ll
7 3 bench/z3/optimized/algebraic_numbers.cpp.ll
3 2 bench/z3/optimized/smt_context.cpp.ll
13 14 bench/z3/optimized/upolynomial_factorization.cpp.ll
28 30 bench/zed-rs/optimized/553y3uma3m7pxzk4dar8hjwb6.ll
6 5 bench/zxing/optimized/PDFDetector.cpp.ll
5 4 bench/zxing/optimized/ReadBarcode.cpp.ll

dtcxzyw
dtcxzyw commented Nov 3, 2024
View reviewed changes
bench/stb/optimized/stb_image.c.ll
%81 = call align 8 ptr @llvm.threadlocal.address.p0(ptr align 8 @stbi__g_failure_reason)
store ptr @.str.87, ptr %81, align 8
br label %return

if.then245: ; preds = %for.inc241.us
for.end243: ; preds = %for.inc241.us
%tobool244.not = icmp eq ptr %scanline.1.us, null
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/nothings/stb/blob/2e2bef463a5b53ddf8bb788e25da6b8506314c08/stb_image.h#L7282-L7283

dtcxzyw
dtcxzyw commented Nov 3, 2024
View reviewed changes
bench/nuttx/optimized/sched_mergeprioritized.c.ll
store ptr %28, ptr %30, align 8
%31 = load ptr, ptr %8, align 8
store ptr %31, ptr %15, align 8
%27 = icmp eq ptr %19, null
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression.

bench/openusd/optimized/stbImage.cpp.ll
%270 = call align 8 ptr @llvm.threadlocal.address.p0(ptr align 8 @_ZL22stbi__g_failure_reason)
store ptr @.str.107, ptr %270, align 8
br label %._crit_edge60.thread

._crit_edge60: ; preds = %._crit_edge56.us
%.not141 = icmp eq ptr %.1118.us, null
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression.

@dtcxzyw
Copy link
Owner Author

dtcxzyw commented Nov 3, 2024

/add-label regression,reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
regression reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtcxzyw @goldsteinn