Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit: PR121892 #1924

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

pre-commit: PR121892 #1924

wants to merge 2 commits into from

Conversation

dtcxzyw
Copy link
Owner

@dtcxzyw dtcxzyw commented Jan 7, 2025

Link: llvm/llvm-project#121892
Requested by: @dtcxzyw

@github-actions github-actions bot mentioned this pull request Jan 7, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

runner: buildkitsandbox
baseline: llvm/llvm-project@653a547
patch: llvm/llvm-project#121892
sha256: 44e85fa844ea05ec382865a13e23ce157f89c6cdc0e00d2474a2ca312006d403
commit: 9b72f07

32 files changed, 8530 insertions(+), 8235 deletions(-)

Improvements:
  correlated-value-propagation.NumShlNSW 97822 -> 97832 +0.01%
  correlated-value-propagation.NumShlNW 220543 -> 220557 +0.01%
  correlated-value-propagation.NumMulNSW 57714 -> 57717 +0.01%
  correlated-value-propagation.NumShlNUW 122721 -> 122725 +0.00%
  correlated-value-propagation.NumNSW 410496 -> 410509 +0.00%
  correlated-value-propagation.NumMulNW 101212 -> 101215 +0.00%
  correlated-value-propagation.NumNW 760911 -> 760928 +0.00%
  correlated-value-propagation.NumNUW 351037 -> 351041 +0.00%
  instcombine.NegatorTotalNegationsAttempted 17751070 -> 17751123 +0.00%
  licm.NumHoisted 4030623 -> 4030631 +0.00%
Regressions:
  instcombine.NegatorNumTreesNegated 35891 -> 35868 -0.06%
  instcombine.NegatorNumInstructionsNegatedSuccess 45409 -> 45386 -0.05%
  instcombine.NegatorNumInstructionsCreatedTotal 49185 -> 49162 -0.05%
  instcombine.NegatorMaxInstructionsCreated 12682 -> 12681 -0.01%
  jump-threading.NumFolds 2016614 -> 2016573 -0.00%
  gvn.NumGVNEqProp 341441 -> 341440 -0.00%
  sccp.NumDeadBlocks 718032 -> 718030 -0.00%
  instcombine.NumDeadInst 33192071 -> 33192013 -0.00%
  memdep.NumCacheCompleteNonLocalPtr 4141840 -> 4141833 -0.00%
  early-cse.NumSimplify 25472481 -> 25472445 -0.00%

9b72f07 pre-commit: Update
4 4 bench/linux/optimized/huf_decompress.ll
6 4 bench/pbrt-v4/optimized/aggregates.cpp.ll
4 2 bench/pbrt-v4/optimized/lightsamplers.cpp.ll
10 6 bench/postgres/optimized/subscriptioncmds.ll
283 279 bench/postgres/optimized/tsvector_op.ll
23 21 bench/quickjs/optimized/libbf.ll
46 44 bench/wireshark/optimized/astringlist_list_model.cpp.ll
13 11 bench/wireshark/optimized/coloring_rules_model.cpp.ll
33 31 bench/wireshark/optimized/column_list_model.cpp.ll
246 238 bench/wireshark/optimized/display_filter_expression_dialog.cpp.ll
17 15 bench/wireshark/optimized/extcap_argument.cpp.ll
124 120 bench/wireshark/optimized/io_graph_dialog.cpp.ll
15 10 bench/wireshark/optimized/packet_list.cpp.ll
48 46 bench/wireshark/optimized/resolved_addresses_models.cpp.ll
41 39 bench/wireshark/optimized/uat_model.cpp.ll

dtcxzyw
dtcxzyw commented Jan 7, 2025
View reviewed changes
bench/pbrt-v4/optimized/aggregates.cpp.ll
@@ -6178,12 +6181,11 @@ for.end163: ; preds = %for.body153
store float %.sroa.speculated.i10.i108, ptr %agg.tmp169330.sroa.7.0.agg.tmp1.i.sroa_idx, align 8
%agg.tmp169330.sroa.8.0.agg.tmp1.i.sroa_idx = getelementptr inbounds nuw i8, ptr %agg.tmp1.i, i64 28
store i32 %minCostSplitBucket.1, ptr %agg.tmp169330.sroa.8.0.agg.tmp1.i.sroa_idx, align 4
%cmp1720.i.i = icmp eq i32 %start, %end
%cmp1720.i.i = icmp eq i64 %add.ptr.i328.idx, %.idx
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be folded into icmp eq i32 %start, %end. It is weird that it doesn't happen.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should further relax one-use constraint like llvm/llvm-project#76384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dtcxzyw