Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit: PR122165 #1932

Closed
wants to merge 2 commits into from
Closed

pre-commit: PR122165 #1932

wants to merge 2 commits into from

Conversation

dtcxzyw
Copy link
Owner

@dtcxzyw dtcxzyw commented Jan 9, 2025

Link: llvm/llvm-project#122165
Requested by: @nikic

@github-actions github-actions bot mentioned this pull request Jan 9, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

runner: buildkitsandbox
baseline: llvm/llvm-project@24a92f5
patch: llvm/llvm-project#122165
sha256: 4c5554371cc04c08d711463642275f14f41553665a79a625573778e9a3a218c4
commit: 61b3a75

37 files changed, 987 insertions(+), 877 deletions(-)

Improvements:
  reassociate.NumChanged 4312303 -> 4312482 +0.00%
  instcombine.NumTwoIterations 17213789 -> 17214034 +0.00%
  instcombine.NumCombined 97971803 -> 97972533 +0.00%
  simplifycfg.NumHoistCommonCode 617378 -> 617382 +0.00%
  simplifycfg.NumSpeculations 313717 -> 313718 +0.00%
  simplifycfg.NumHoistCommonInstrs 1760442 -> 1760446 +0.00%
  globalsmodref-aa.NumNoMemFunctions 779989 -> 779990 +0.00%
  globalsmodref-aa.NumReadMemFunctions 1139540 -> 1139541 +0.00%
  instcombine.NumWorklistIterations 58152727 -> 58152730 +0.00%
Regressions:
  correlated-value-propagation.NumAddNUW 159205 -> 159204 -0.00%
  instcombine.NumOneIteration 40938938 -> 40938696 -0.00%
  correlated-value-propagation.NumAddNW 345005 -> 345003 -0.00%
  correlated-value-propagation.NumAddNSW 185800 -> 185799 -0.00%
  instcombine.NumDeadInst 33194899 -> 33194779 -0.00%
  correlated-value-propagation.NumNUW 351032 -> 351031 -0.00%
  correlated-value-propagation.NumNW 760898 -> 760896 -0.00%
  correlated-value-propagation.NumNSW 410488 -> 410487 -0.00%
  instcombine.NegatorTotalNegationsAttempted 17751448 -> 17751436 -0.00%
  instcombine.NegatorNumValuesVisited 18501212 -> 18501200 -0.00%

61b3a75 pre-commit: Update
79 87 bench/abseil-cpp/optimized/numbers.cc.ll
6 6 bench/arrow/optimized/basic_decimal.cc.ll
3 3 bench/boost/optimized/src.ll
31 31 bench/c3c/optimized/bigint.c.ll
4 4 bench/clamav/optimized/qtmd.c.ll
1 1 bench/cpython/optimized/dtoa.ll
20 28 bench/duckdb/optimized/ub_duckdb_common_types.cpp.ll
2 2 bench/meshlab/optimized/gltf_loader.cpp.ll
8 8 bench/openjdk/optimized/mlib_c_ImageLookUp_f.ll
56 56 bench/php/optimized/hash_ripemd.ll
16 16 bench/php/optimized/hash_snefru.ll
7 7 bench/postgres/optimized/nodeHash.ll

nikic
nikic reviewed Jan 9, 2025
View reviewed changes
bench/abseil-cpp/optimized/numbers.cc.ll
@@ -1134,18 +1134,18 @@ if.then98.i: ; preds = %if.then92.i

if.else105.i: ; preds = %if.then92.i
%5 = tail call range(i64 0, 65) i64 @llvm.ctlz.i64(i64 %conv101.i, i1 true)
%shl.i.i = shl i64 %conv101.i, %5
%6 = tail call i64 @llvm.fshl.i64(i64 %conv101.i, i64 0, i64 %5)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing fold: https://alive2.llvm.org/ce/z/3oTEop

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reported: llvm/llvm-project#122235

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, I wrote this issue before I saw your comment. Masking the shift amount instead of making it a pre-condition may be better...

@nikic
Copy link

nikic commented Jan 9, 2025

/add-label reviewed
/close

@github-actions github-actions bot closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic left review comments

Assignees
No one assigned
Labels
reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtcxzyw @nikic