Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit: test PR76700 #83

Closed
wants to merge 2 commits into from
Closed

pre-commit: test PR76700 #83

wants to merge 2 commits into from

Conversation

dtcxzyw
Copy link
Owner

@dtcxzyw dtcxzyw commented Jan 2, 2024

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

baseline: llvm/llvm-project@9e1ad3c
patch: llvm/llvm-project#76700
sha256: bec853b07a7fba7851b230ee82d458a98ff4da762cad3ce4109359ba9c1ea2c0
commit: b2c91d6
b2c91d6 pre-commit: Update
bench/abseil-cpp/optimized/charconv.cc.ll
bench/abseil-cpp/optimized/demangle.cc.ll
bench/arrow/optimized/int_util.cc.ll
bench/arrow/optimized/uri.cc.ll
bench/assimp/optimized/AMFImporter_Postprocess.cpp.ll
bench/assimp/optimized/MDLMaterialLoader.cpp.ll
bench/assimp/optimized/glTF2Exporter.cpp.ll
bench/assimp/optimized/glTF2Importer.cpp.ll
bench/assimp/optimized/glTFExporter.cpp.ll
bench/assimp/optimized/glTFImporter.cpp.ll
bench/cpython/optimized/_testbuffer.ll
bench/cpython/optimized/dictobject.ll
bench/cpython/optimized/memoryobject.ll
bench/cpython/optimized/pystrtod.ll
bench/cpython/optimized/weakrefobject.ll
bench/duckdb/optimized/ub_duckdb_aggr_distributive.cpp.ll
bench/duckdb/optimized/ub_duckdb_aggr_holistic.cpp.ll
bench/duckdb/optimized/ub_duckdb_aggr_nested.cpp.ll
bench/duckdb/optimized/ub_duckdb_common.cpp.ll
bench/duckdb/optimized/ub_duckdb_common_arrow.cpp.ll
bench/duckdb/optimized/ub_duckdb_common_operators.cpp.ll
bench/duckdb/optimized/ub_duckdb_common_types.cpp.ll
bench/duckdb/optimized/ub_duckdb_execution_index_art.cpp.ll
bench/duckdb/optimized/ub_duckdb_func_cast.cpp.ll
bench/duckdb/optimized/ub_duckdb_func_date.cpp.ll
bench/duckdb/optimized/ub_duckdb_func_generic.cpp.ll
bench/duckdb/optimized/ub_duckdb_func_ops.cpp.ll
bench/duckdb/optimized/ub_duckdb_func_ops_main.cpp.ll
bench/duckdb/optimized/ub_duckdb_func_scalar.cpp.ll
bench/duckdb/optimized/ub_duckdb_func_seq.cpp.ll
bench/duckdb/optimized/ub_duckdb_func_string.cpp.ll
bench/duckdb/optimized/ub_duckdb_func_string_main.cpp.ll
bench/duckdb/optimized/ub_duckdb_main.cpp.ll
bench/duckdb/optimized/ub_duckdb_operator_csv_scanner.cpp.ll
bench/duckdb/optimized/ub_duckdb_optimizer_rules.cpp.ll
bench/eastl/optimized/TestDeque.cpp.ll
bench/entt/optimized/meta_context.cpp.ll
bench/entt/optimized/meta_data.cpp.ll
bench/entt/optimized/meta_type.cpp.ll
bench/entt/optimized/registry.cpp.ll
bench/flac/optimized/bitwriter.c.ll
bench/flac/optimized/encode.c.ll
bench/fmt/optimized/chrono-test.cc.ll
bench/fmt/optimized/compile-test.cc.ll
bench/fmt/optimized/enforce-checks-test.cc.ll
bench/fmt/optimized/format-impl-test.cc.ll
bench/fmt/optimized/format-test.cc.ll
bench/fmt/optimized/format.cc.ll
bench/fmt/optimized/gtest-extra.cc.ll
bench/fmt/optimized/header-only-test.cc.ll
bench/fmt/optimized/os.cc.ll
bench/fmt/optimized/printf-test.cc.ll
bench/fmt/optimized/ranges-test.cc.ll
bench/fmt/optimized/std-test.cc.ll
bench/fmt/optimized/unicode-test.cc.ll
bench/fmt/optimized/util.cc.ll
bench/fmt/optimized/xchar-test.cc.ll
bench/grpc/optimized/call.cc.ll
bench/grpc/optimized/deadline_filter.cc.ll
bench/grpc/optimized/grpc_ares_wrapper.cc.ll
bench/grpc/optimized/grpclb.cc.ll
bench/grpc/optimized/outlier_detection.cc.ll
bench/grpc/optimized/xds_cluster_impl.cc.ll
bench/grpc/optimized/xds_override_host.cc.ll
bench/hermes/optimized/CompilerDriver.cpp.ll
bench/hermes/optimized/ESTreeIRGen-func.cpp.ll
bench/hermes/optimized/IREval.cpp.ll
bench/hermes/optimized/JSParserImpl-ts.cpp.ll
bench/hermes/optimized/JSParserImpl.cpp.ll
bench/icu/optimized/number_affixutils.ll
bench/icu/optimized/numparse_affixes.ll
bench/icu/optimized/regexcmp.ll
bench/icu/optimized/tzfmt.ll
bench/icu/optimized/uniset.ll
bench/jemalloc/optimized/sc.ll
bench/jemalloc/optimized/sc.pic.ll
bench/jemalloc/optimized/sc.sym.ll
bench/llama.cpp/optimized/llama.cpp.ll
bench/miniaudio/optimized/unity.c.ll
bench/nlohmann_json/optimized/unit.cpp.ll
bench/node/optimized/libnode.crypto_util.ll
bench/nuklear/optimized/unity.c.ll
bench/oiio/optimized/CineonHeader.cpp.ll
bench/oiio/optimized/argparse.cpp.ll
bench/oiio/optimized/benchmark.cpp.ll
bench/oiio/optimized/bmpinput.cpp.ll
bench/oiio/optimized/bmpoutput.cpp.ll
bench/oiio/optimized/cineoninput.cpp.ll
bench/oiio/optimized/color_ocio.cpp.ll
bench/oiio/optimized/ddsinput.cpp.ll
bench/oiio/optimized/dpxinput.cpp.ll
bench/oiio/optimized/dpxoutput.cpp.ll
bench/oiio/optimized/environment.cpp.ll
bench/oiio/optimized/errorhandler.cpp.ll
bench/oiio/optimized/exrinput.cpp.ll
bench/oiio/optimized/exroutput.cpp.ll
bench/oiio/optimized/filesystem.cpp.ll
bench/oiio/optimized/fitsinput.cpp.ll
bench/oiio/optimized/fitsoutput.cpp.ll

@dtcxzyw
Copy link
Owner Author

dtcxzyw commented Jan 2, 2024

Regression:

diff --git a/bench/redis/optimized/t_set.ll b/bench/redis/optimized/t_set.ll
index 857755c3..73dcbac8 100644
--- a/bench/redis/optimized/t_set.ll
+++ b/bench/redis/optimized/t_set.ll
@@ -4665,7 +4665,7 @@ if.end110:                                        ; preds = %if.else108, %if.the
 
 if.end114:                                        ; preds = %if.end87
   %call115 = call ptr @dictCreate(ptr noundef nonnull @sdsReplyDictType) #10
-  %mul116 = mul i64 %count.0, 3
+  %mul116 = mul i64 %2, 3
   %cmp117 = icmp ugt i64 %mul116, %retval.0.i
   br i1 %cmp117, label %if.then119, label %if.else173
 
@@ -4713,15 +4713,19 @@ while.end148:                                     ; preds = %while.cond123
   %34 = load i64, ptr %arrayidx151, align 8
   %add = add i64 %34, %33
   %cmp152 = icmp eq i64 %add, %retval.0.i
-  br i1 %cmp152, label %while.body166, label %cond.false161
+  br i1 %cmp152, label %while.cond163.preheader, label %cond.false161
+
+while.cond163.preheader:                          ; preds = %while.end148
+  %cmp164107 = icmp ugt i64 %retval.0.i, %count.0
+  br i1 %cmp164107, label %while.body166, label %if.end195
 
 cond.false161:                                    ; preds = %while.end148
   call void @_serverAssert(ptr noundef nonnull @.str.15, ptr noundef nonnull @.str.1, i32 noundef 1171) #10
   call void @abort() #11
   unreachable
 
-while.body166:                                    ; preds = %while.end148, %while.body166
-  %size.1108 = phi i64 [ %dec171, %while.body166 ], [ %retval.0.i, %while.end148 ]
+while.body166:                                    ; preds = %while.cond163.preheader, %while.body166
+  %size.1108 = phi i64 [ %dec171, %while.body166 ], [ %retval.0.i, %while.cond163.preheader ]
   %call167 = call ptr @dictGetFairRandomKey(ptr noundef %call115) #10
   %call168 = call ptr @dictGetKey(ptr noundef %call167) #10
   %call169 = call ptr @dictUnlink(ptr noundef %call115, ptr noundef %call168) #10

@dtcxzyw
Copy link
Owner Author

dtcxzyw commented Jan 5, 2024

Regression:

diff --git a/bench/redis/optimized/t_set.ll b/bench/redis/optimized/t_set.ll
index 857755c3..73dcbac8 100644
--- a/bench/redis/optimized/t_set.ll
+++ b/bench/redis/optimized/t_set.ll
@@ -4665,7 +4665,7 @@ if.end110:                                        ; preds = %if.else108, %if.the
 
 if.end114:                                        ; preds = %if.end87
   %call115 = call ptr @dictCreate(ptr noundef nonnull @sdsReplyDictType) #10
-  %mul116 = mul i64 %count.0, 3
+  %mul116 = mul i64 %2, 3
   %cmp117 = icmp ugt i64 %mul116, %retval.0.i
   br i1 %cmp117, label %if.then119, label %if.else173
 
@@ -4713,15 +4713,19 @@ while.end148:                                     ; preds = %while.cond123
   %34 = load i64, ptr %arrayidx151, align 8
   %add = add i64 %34, %33
   %cmp152 = icmp eq i64 %add, %retval.0.i
-  br i1 %cmp152, label %while.body166, label %cond.false161
+  br i1 %cmp152, label %while.cond163.preheader, label %cond.false161
+
+while.cond163.preheader:                          ; preds = %while.end148
+  %cmp164107 = icmp ugt i64 %retval.0.i, %count.0
+  br i1 %cmp164107, label %while.body166, label %if.end195
 
 cond.false161:                                    ; preds = %while.end148
   call void @_serverAssert(ptr noundef nonnull @.str.15, ptr noundef nonnull @.str.1, i32 noundef 1171) #10
   call void @abort() #11
   unreachable
 
-while.body166:                                    ; preds = %while.end148, %while.body166
-  %size.1108 = phi i64 [ %dec171, %while.body166 ], [ %retval.0.i, %while.end148 ]
+while.body166:                                    ; preds = %while.cond163.preheader, %while.body166
+  %size.1108 = phi i64 [ %dec171, %while.body166 ], [ %retval.0.i, %while.cond163.preheader ]
   %call167 = call ptr @dictGetFairRandomKey(ptr noundef %call115) #10
   %call168 = call ptr @dictGetKey(ptr noundef %call167) #10
   %call169 = call ptr @dictUnlink(ptr noundef %call115, ptr noundef %call168) #10

I guess I know how to fix the regression :) Will merge this PR first.

This was referenced Jan 5, 2024
Open
Merged
@dtcxzyw dtcxzyw force-pushed the main branch 9 times, most recently from 296115f to 7225cd8 Compare September 17, 2024 07:23
@dtcxzyw dtcxzyw closed this Oct 22, 2024
@dtcxzyw dtcxzyw deleted the test-pr76700 branch October 22, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
regression reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dtcxzyw