Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP:kitex interceptor #8

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

WIP:kitex interceptor #8

wants to merge 2 commits into from

Conversation

zmhbh
Copy link

@zmhbh zmhbh commented May 22, 2023

No description provided.

@zmhbh zmhbh changed the title kitex interceptor WIP:kitex interceptor May 22, 2023
@zmhbh zmhbh force-pushed the kitex-interceptor branch 2 times, most recently from ad126b3 to 6e86ec7 Compare May 22, 2023 12:59
@yedf2
Copy link
Contributor

yedf2 commented May 22, 2023

这种实现方式不对，如果支持一个kitex这么写的话，那么支持更多的微服务协议呢？每种微服务都这么实现的话，到时候就会很乱。
你再参考一下dtm支持go-zero，kratos的驱动方式

@zmhbh zmhbh force-pushed the kitex-interceptor branch 4 times, most recently from b3e1d39 to 2ec83a1 Compare May 23, 2023 06:31
@zmhbh zmhbh force-pushed the kitex-interceptor branch from 2ec83a1 to db6565d Compare May 23, 2023 06:32
@zmhbh
Copy link
Author

zmhbh commented May 23, 2023 •
edited
Loading

这种实现方式不对，如果支持一个kitex这么写的话，那么支持更多的微服务协议呢？每种微服务都这么实现的话，到时候就会很乱。 你再参考一下dtm支持go-zero，kratos的驱动方式

你好，我去看了下。其实我一开始也不想在DTM层做，但是要实现interceptor的话，似乎只能这么处理了。因为interceptor中，需要涉及的方法都是私有的，在外部，无法调用到。

kitex和go-zero的区别是，go-zero还是用的GRPC，但是kitex其实是字节跳动重新抽象了，kitex支持grpc和thrift，可以二选一。所以某种意义上说，kitex和http，grpc是并列关系。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zmhbh @yedf2 @jason-ksztone