Using parse_parens, parse_braces, parse_brackets instead of macros. #1519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't understand why we have macros parenthesized, braced and bracketed.
You cannot use '?' with them, because these macros return the ParseBuffer from expression, and in case of an error, they return it from the current function.
Simple functions are better, than macros.
or
In first variant we have uninitialized variable.
Example from syn crate:
Perhaps we should remove these macros and make the listed functions and the values returned by them public?