Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor span error resolves #89 #105

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Refactor span error resolves #89 #105

merged 4 commits into from
Aug 3, 2023

Conversation

brandonsimpson21
Copy link
Contributor

@brandonsimpson21 brandonsimpson21 commented Jul 18, 2023 •
edited by fpoli
Loading

functions with signature

fn(..) -> Result<T, SpanError>

become

fn(..) -> syn::Result<T>

feedback welcome!

Closes #89

@brandonsimpson21 brandonsimpson21 changed the title Refactor span error Refactor span error resolves #89 Jul 18, 2023
fpoli
fpoli approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@fpoli fpoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It looks good to me.

@fpoli fpoli added this pull request to the merge queue Aug 3, 2023
Merged via the queue into duchess-rs:main with commit 43c6bc5 Aug 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpoli fpoli fpoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor SpanError to syn::Error
2 participants
@brandonsimpson21 @fpoli