feat: add tests showing the result of iceberg conversion to DuckDB #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EpsilonPrime
changed the title
|
@samansmink Any thoughts on this PR? Is it worth codifying the behavior of the iceberg conversion to DuckDB? |
|
yea looks good! I've started CI |
|
Semi-related question from a lurker on this project: does this test suite imply the extension does not support reading of Iceberg struct and array types? It seems like they should map rather straight-forwardly to Duckb's struct and list types, respectively. |
|
They should but they weren't available in the table. I could construct another dataset with struct and lists in them. |
EpsilonPrime
force-pushed
the
typeof_testing
branch
from
20d3275 to
c8f5476
Compare
|
rebased |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.