Support DATE and TIME bind parameter types #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticlibs
force-pushed
the
date_and_time_bind_params
branch
2 times, most recently
from
6e03103 to
9fb4a93
Compare
Support for `DATE` and `TIME` value was lacking in `SQLBindParameter`/`SQLExecute`. This change adds such support the same way as `TIMESTAMP` parameters are handled. Besides that, when fetching records with `SQLGetData` there was no conversion from DB `TIME` type to ODBC `TIMESTAMP` type. Such conversion for some reason does not exist in the engine. But PyODBC uses it by always fetching `TIME` columns as `TIMESTAMP`. This conversion is added manually. Testing: existing test adjusted when fetching `TIME` as `TIMESTAMP`, new test is added to cover `SQLBindParameter` with `TIMESTAMP`, `DATE` and `TIME` types. Fixes: duckdb#91
staticlibs
force-pushed
the
date_and_time_bind_params
branch
from
9fb4a93 to
582b304
Compare
|
Is there any update or timeline to merge this PR and fix this issue? It is quite critical for our prod workflows and we would greatly appreciate it being addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for
DATEandTIMEvalue was lacking inSQLBindParameter/SQLExecute. This change adds such support the same way asTIMESTAMPparameters are handled.Besides that, when fetching records with
SQLGetDatathere was no conversion from DBTIMEtype to ODBCTIMESTAMPtype. Such conversion for some reason does not exist in the engine. But PyODBC uses it by always fetchingTIMEcolumns asTIMESTAMP. This conversion is added manually.Testing: existing test adjusted when fetching
TIMEasTIMESTAMP, new test is added to coverSQLBindParameterwithTIMESTAMP,DATEandTIMEtypes.Fixes: #91