Add clickhouse to regression script #69
Conversation
| install_solution("datatable") | ||
| elif solution == "clickhouse": | ||
| install_solution("clickhouse") | ||
| install_solution("polars") |
There was a problem hiding this comment.
polars was needed because clickhouse outputs NA as a result in the time.csv file. The current verification script throws these out before checking that all results are the same. If only clickhouse is run, then the results are empty after NA is thrown out. So if I add polars then there are still query results that can be verified. Polars was chosen because it installs quickly and runs quickly.
Feel free to modify how clickhouse writes to time.csv to fix this. It doesn't have to be in this PR though, can be later
There was a problem hiding this comment.
clickhouse/clickhouse-parse-log.R
This is the place to fix it
| # needed because clickhouse for some reason produces an error the first | ||
| # time a benchmark is run. The next benchmark run will work and overwrite the |
There was a problem hiding this comment.
Let's check if it remains after my PR will be merged. I think it will be not necessary(or I will check what happens)
|
Add click house to the regression script as well.