Skip to content

Add support for local overrides for feature flags #2850

Add support for local overrides for feature flags

Add support for local overrides for feature flags #2850

Triggered via pull request November 13, 2024 14:54
Status Failure
Total duration 6m 7s
Artifacts 2

pr.yml

on: pull_request
Run SwiftLint
36s
Run SwiftLint
Run unit tests (macOS)
4m 9s
Run unit tests (macOS)
Run unit tests (iOS)
5m 52s
Run unit tests (iOS)
Create Asana Task
0s
Create Asana Task
Close Asana Task
0s
Close Asana Task
Fit to window
Zoom out
Zoom in

Annotations

8 errors, 22 warnings, and 10 notices
Run SwiftLint: Tests/BrowserServicesKitTests/FeatureFlagging/DefaultFeatureFlaggerTests.swift#L32
Lines should not have trailing whitespace (trailing_whitespace)
Run SwiftLint: Tests/BrowserServicesKitTests/FeatureFlagging/DefaultFeatureFlaggerTests.swift#L37
Lines should not have trailing whitespace (trailing_whitespace)
Run SwiftLint: Tests/BrowserServicesKitTests/FeatureFlagging/DefaultFeatureFlaggerTests.swift#L41
Lines should not have trailing whitespace (trailing_whitespace)
Run SwiftLint: Tests/BrowserServicesKitTests/FeatureFlagging/DefaultFeatureFlaggerTests.swift#L45
Lines should not have trailing whitespace (trailing_whitespace)
Run SwiftLint: Tests/BrowserServicesKitTests/FeatureFlagging/TestFeatureFlag.swift#L1
Header comments should be consistent with project patterns (file_header)
Run unit tests (macOS): Tests/BrowserServicesKitTests/ContentBlocker/SurrogatesUserScriptTests.swift#L325
testWhenThereIsCTLSurrogateRuleThenSurrogateIsInjected, XCTAssertNil failed: "Error Domain=WKErrorDomain Code=4 "A JavaScript exception occurred" UserInfo={WKJavaScriptExceptionLineNumber=1, WKJavaScriptExceptionMessage=TypeError: undefined is not an object (evaluating 'window.ctlSurrT.ping'), WKJavaScriptExceptionColumnNumber=16, WKJavaScriptExceptionSourceURL=test://example.com, NSLocalizedDescription=A JavaScript exception occurred}"
Run unit tests (macOS): Tests/BrowserServicesKitTests/ContentBlocker/SurrogatesUserScriptTests.swift#L342
testWhenThereIsCTLSurrogateRuleThenSurrogateIsInjected, Asynchronous wait failed: Exceeded timeout of 15 seconds, with unfulfilled expectations: "Validated surrogate injection".
Run unit tests (macOS)
Process completed with exit code 1.
Run unit tests (macOS)
The following actions use a deprecated Node.js version and will be forced to run on node20: mikepenz/action-junit-report@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run unit tests (macOS): .build/arm64-apple-macosx/debug/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Run unit tests (macOS): Sources/Configuration/ConfigurationFetching.swift#L129
'fetch()' is deprecated: Please use 'APIService' instead.
Run unit tests (macOS): Sources/Configuration/ConfigurationFetching.swift#L129
'fetch()' is deprecated: Please use 'APIService' instead.
Run unit tests (macOS): Sources/DDGSync/internal/RemoteAPIRequestCreator.swift#L56
'fetch()' is deprecated: Please use 'APIService' instead.
Run unit tests (macOS): Sources/DDGSync/internal/RemoteAPIRequestCreator.swift#L56
'fetch()' is deprecated: Please use 'APIService' instead.
Run unit tests (macOS): Sources/DDGSync/internal/RemoteAPIRequestCreator.swift#L56
'fetch()' is deprecated: Please use 'APIService' instead.
Run unit tests (macOS): Sources/DDGSync/internal/RemoteAPIRequestCreator.swift#L56
'fetch()' is deprecated: Please use 'APIService' instead.
Run unit tests (macOS): Sources/DDGSync/internal/RemoteAPIRequestCreator.swift#L56
'fetch()' is deprecated: Please use 'APIService' instead.
Run unit tests (macOS): Sources/DDGSync/internal/RemoteAPIRequestCreator.swift#L56
'fetch()' is deprecated: Please use 'APIService' instead.
Run unit tests (macOS): Sources/DDGSync/internal/RemoteAPIRequestCreator.swift#L56
'fetch()' is deprecated: Please use 'APIService' instead.
Run unit tests (iOS)
The following actions use a deprecated Node.js version and will be forced to run on node20: mikepenz/action-junit-report@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run unit tests (iOS): DerivedData/Build/Products/Debug/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Run unit tests (iOS): DerivedData/Build/Products/Debug/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Run unit tests (iOS): DerivedData/Build/Products/Debug/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Run unit tests (iOS): DerivedData/Build/Products/Debug/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Run unit tests (iOS): DerivedData/Build/Products/Debug/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Run unit tests (iOS): DerivedData/Build/Products/Debug/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Run unit tests (iOS): DerivedData/Build/Products/Debug/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Run unit tests (iOS): DerivedData/Build/Products/Debug/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Run unit tests (iOS): DerivedData/Build/Products/Debug/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Run unit tests (iOS): DerivedData/Build/Products/Debug/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestAfterCustomSchemeRequest
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestAfterCustomSchemeRequestWithFailureAfterDidStartNavigation
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestAfterCustomSchemeRequestWithFailureAfterWillStartNavigation
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestAfterCustomSchemeRequestWithFailureBeforeWillStartNavigation
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequest
Run unit tests (macOS)
Skipped NavigationTests.DistributedNavigationDelegateTests.testSimulatedRequestWithData
Run unit tests (macOS)
Skipped CommonTests.URLExtensionTests.test_navigational_urls_are_valid
Run unit tests (macOS)
Skipped CommonTests.URLExtensionTests.test_non_valid_urls
Run unit tests (macOS)
Skipped CommonTests.URLExtensionTests.testBasicAuthCredential
Run unit tests (macOS)
Skipped CommonTests.URLExtensionTests.testURLRemovingBasicAuthCredential

Artifacts

Produced during runtime
Name Size
build-log.txt
49.7 KB
ios-build-log.txt
151 KB