Behavioral toast updates #1063
Merged
Behavioral toast updates #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaceklyp
commented
Nov 6, 2024
| let settings = getSettingsFromConfig() | ||
|
|
||
| resetDismissStreakIfNeeded(dismissStreakResetDays: settings.dismissStreakResetDays) | ||
| // TODO: Uncomment before merging -> this is just for review builds so it is easier to test |
There was a problem hiding this comment.
This is just for the purpose of Ship review so it is easier to test the feature but should be removed before merging.
dus7
approved these changes
Nov 7, 2024
| } | ||
|
|
||
| func isLessThan48HoursAgo() -> Bool { | ||
| self > Date().addingTimeInterval(-48 * 60 * 60) |
There was a problem hiding this comment.
Technically isLessThan(daysAgo: 2) could be used as a backing implementation here. But that's just a nitpick.
mgurgel
pushed a commit
that referenced
this pull request
Nov 18, 2024
Task/Issue URL: iOS PR: duckduckgo/iOS#3552 macOS PR: duckduckgo/macos-browser#3523 **Description**: We’re introducing a behavioral toast on macOS, which required moving logic from the iOS client into BSK. Some of this logic has been updated—specifically, we now only support an event for 3 consecutive refreshes, whereas previously, we had multiple events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL:
iOS PR: duckduckgo/iOS#3552
macOS PR: duckduckgo/macos-browser#3523
What kind of version bump will this require?: Major
Description:
We’re introducing a behavioral toast on macOS, which required moving logic from the iOS client into BSK. Some of this logic has been updated—specifically, we now only support an event for 3 consecutive refreshes, whereas previously, we had multiple events.
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template