Improve VPN underlying error detail #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
approved these changes
May 2, 2024
alessandroboron
requested review from
alessandroboron
and removed request for
alessandroboron
diegoreymendez
deleted the
diego/improve-error-reporting-for-NetworkProtectionClientError
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1207221937455192/f
iOS PR: duckduckgo/iOS#2813
macOS PR: duckduckgo/macos-browser#2736
What kind of version bump will this require?: Major/Minor/Patch
Description
Improves VPN underlying error detail for
NetworkProtectionClientErrorandWireGuardError.Testing
dryModefor the packet tunnel provider.PacketTunnelProviderright after the tunnel starts throw anyNetworkProtectionClientErrororWireGuardErrorwith underlying error information.Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation