Improvements to AutofillSettingStatus to remove unnecessary LAContext() calls #3606
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201462886803403/1208801010014864/f
Tech Design URL:
CC:
Description:
AutofillSettingStatus refactored to cache a users device authentication status (i.e. do they have a passcode set on their device which is a requirement for the autofill feature) while the app is in foreground instead of constantly querying every time a check is required.
LAcontext().canEvaluatePolicy(.deviceOwnerAuthentication, error: &error)
is called which is currently the source of a steady number of ongoing crashes.LAcontext()
call to run on main which should prevent future crashes.While testing I also discovered that the incorrect UI state was being presented on the Passwords screen for users who do not have any device security enabled, which I’ve fixed here also
Steps to test this PR:
Save and autofill passwords
enabledAutofillSettingStatus
set a breakpoint at line 48result = LAContext().canEvaluatePolicy(.deviceOwnerAuthentication, error: &error)
[fill.dev](https://fill.dev/form/login-simple)
, enter new credentials and save them when promptedfill.dev
login webpage and confirm that autofill prompts are back<!—
Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you know do not need explicit testing.
Using a simulator where a physical device is unavailable is acceptable.
—>
Definition of Done (Internal Only):
Copy Testing:
’
rather than’
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template