Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Malware protection: bump BSK #3617

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Malware protection: bump BSK #3617

wants to merge 2 commits into from
+22 −23

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Nov 25, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/481882893211075/1208033567421351/f

Description:

  • BSK bump for macOS phishing detection -> Malicious site protection rename

Steps to test this PR:

  1. validate no changes, CI passes

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SabrinaTardio SabrinaTardio SabrinaTardio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mallexxx @SabrinaTardio