This repository has been archived by the owner on Feb 24, 2025. It is now read-only.
Client displays correct subscription #3620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em when lacking entitlement
samsymons
reviewed
Nov 27, 2024
Comment on lines
+332
to
+336
| if featureFlagger.localOverrides?.override(for: flag) == nil { | ||
| featureFlagger.localOverrides?.toggleOverride(for: flag) | ||
| } else { | ||
| featureFlagger.localOverrides?.clearOverride(for: flag) | ||
| } |
samsymons
reviewed
Nov 27, 2024
6 tasks
miasma13
changed the title
samsymons
reviewed
Nov 29, 2024
Comment on lines
+122
to
+134
| Task { | ||
| let features = await subscriptionManager.currentSubscriptionFeatures() | ||
|
|
||
| if features.contains(.networkProtection) { | ||
| availableCategories.append(.vpn) | ||
| } | ||
| if features.contains(.dataBrokerProtection) { | ||
| availableCategories.append(.pir) | ||
| } | ||
| if features.contains(.identityTheftRestoration) || features.contains(.identityTheftRestorationGlobal) { | ||
| availableCategories.append(.itr) | ||
| } | ||
| } |
samsymons
approved these changes
Nov 29, 2024
miasma13
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Nov 29, 2024
**Required**: Task/Issue URL: https://app.asana.com/0/1208524871249522/1208379950230747/f iOS PR: duckduckgo/iOS#3620 macOS PR: duckduckgo/macos-browser#3581 What kind of version bump will this require?: Minor **Description**: See https://app.asana.com/0/1208524871249522/1208379950230747/f **Steps to test this PR**: See client PRs **OS Testing**: * [ ] iOS 14 * [ ] iOS 15 * [ ] iOS 16 * [ ] macOS 10.15 * [ ] macOS 11 * [ ] macOS 12 --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
|
samsymons
added a commit
that referenced
this pull request
Nov 29, 2024
# By Bartek Waresiak (3) and others # Via GitHub (1) and others * main: Remove incorrect tests and reenable some of the non-flaky ones (#3653) Update BSK with version including Privacy Stats module for use in the macOS browser (#3651) point to BSK branch and updates (#3636) Release 7.147.0-6 (#3652) Revert incorrect push Client displays correct subscription (#3620) Re-enable pixel tests except for flaky one Remove Special Pages tests Include inactive tabs statistics in daily tab switcher pixel (#3643) Release 7.147.0-5 (#3649) [Release PR] Add StoreKit debugging metadata to the debug menu (#3637) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Nov 30, 2024
# By Bartek Waresiak (3) and others # Via GitHub (1) and others * main: Add support for RMF survey `locale` parameter (#3648) Remove incorrect tests and reenable some of the non-flaky ones (#3653) Update BSK with version including Privacy Stats module for use in the macOS browser (#3651) point to BSK branch and updates (#3636) Release 7.147.0-6 (#3652) Revert incorrect push Client displays correct subscription (#3620) Re-enable pixel tests except for flaky one Remove Special Pages tests Include inactive tabs statistics in daily tab switcher pixel (#3643) Release 7.147.0-5 (#3649) [Release PR] Add StoreKit debugging metadata to the debug menu (#3637) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1208524871249522/1208379950230747/f
Description:
See https://app.asana.com/0/1208524871249522/1208799981662317/f
Steps to test this PR:
See https://app.asana.com/0/0/1208836865988482/f and its parent task.
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template