This repository has been archived by the owner on Feb 24, 2025. It is now read-only.
re-add settings pixels #3716
Merged
re-add settings pixels #3716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brindy
requested review from
a team,
federicocappelli and
mallexxx
and removed request for
a team and
federicocappelli
mallexxx
reviewed
Dec 12, 2024
| case settingsShowFullURLOff | ||
| case settingsDataClearingOpen | ||
| case settingsFireButtonSelectorPressed | ||
| case settingsDataClearingClearDataOpen |
There was a problem hiding this comment.
settingsDataClearingClearDataOpen pixel is not used anywhere
mallexxx
reviewed
Dec 12, 2024
| case settingsDataClearingOpen | ||
| case settingsFireButtonSelectorPressed | ||
| case settingsDataClearingClearDataOpen | ||
| case settingsAutomaticallyClearDataOn |
There was a problem hiding this comment.
settingsAutomaticallyClearDataOn is fired for every action or timing parameter change in the Automatically Clear Data settings screen
mallexxx
suggested changes
Dec 12, 2024
|
Thanks @mallexxx - fixed both of those. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/392891325557410/1207818776591137/f
Tech Design URL:
CC:
Description:
Add pixels for various actions and views in settings.
Steps to test this PR: