Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malicious site protection address bar and privacy dashboard changes #3718

Open
wants to merge 2 commits into
base: alessandro/malicious-site-protection-navigation-detection-async
Choose a base branch
from

Conversation

alessandroboron
Copy link
Contributor

@alessandroboron alessandroboron commented Dec 11, 2024

Task/Issue URL: https://app.asana.com/0/1206329551987282/1208959082985728/f
Tech Design: https://app.asana.com/0/1206329551987282/1207273224076495/f
CC: @not-a-rootkit

Description:

This PR addresses the following:

  1. Updates the Privacy Icon to use the globe asset when visiting special error pages (SSL error included).
  2. Updates the Privacy icon to use the alert asset when the user accepts the risk of visiting a malicious page.
  3. Show an updated privacy dashboard for phishing and malware special error pages.

Steps to test this PR:

Scenario 1 - Special Error Pages show globe icon in the address bar
Ensure that the below URLs show the globe icon in the Address Bar as per Figma Design

  1. http://privacy-test-pages.site/security/badware/phishing.html
  2. http://privacy-test-pages.site/security/badware/malware.html
  3. https://expired.badssl.com/ (or any other SSL error URL)

Scenario 2 - Malicious Sites show alert icon in the address bar

  1. Navigate to the below websites
    a. http://privacy-test-pages.site/security/badware/phishing.html
    b. http://privacy-test-pages.site/security/badware/malware.html
  2. When the special error page is shown, tap “Advanced” button and then tap the “Accept Risk adn Visit Site” button.
  3. Ensure that the address bar show an alert as per Figma Design

Scenario 3 - Malicious Sites show updated privacy dashboard

  1. Navigate to the below websites
    a. http://privacy-test-pages.site/security/badware/phishing.html
    b. http://privacy-test-pages.site/security/badware/malware.html
  2. When the special error page is shown, tap “Advanced” button and then tap the “Accept Risk adn Visit Site” button.
  3. Tap the alert icon to open the Privacy Dashboard.
  4. Ensure that the Privacy dashboard inform the user of deceptive website

Scenario 4 - Accepting visiting SSL Insecure website (Bonus Point)

  1. Navigate to one of the malicious website.
  2. Accept navigating to the website.
  3. Navigate to https://expired.badssl.com/.
  4. Ensure the globe icon is shown instead of the alert icon.
  5. Accept the risk of visiting the site.
  6. Ensure the shield icon is shown instead of the alert icon.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant