Only attempt to refresh auth token when user is authenticated #3721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414709148257752/1208966018277167/f
Description:
Following Increase of 401s in auth api - Darwin we found that the refreshAuthTokenIfNeeded is being called without a proper check if user is authenticated (and tokens are present).
It also includes BSK check -> duckduckgo/BrowserServicesKit@fb809ed
Steps to test this PR:
refreshAuthTokenIfNeeded
was not called and no calls tovalidate_token
endpoint were made.refreshAuthTokenIfNeeded
was properly called with a call tovalidate_token
endpoint.Definition of Done (Internal Only):
Copy Testing:
’
rather than'
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template