Address updater feedback #14813
Annotations
1 error and 11 warnings
|
Run integration tests:
IntegrationTests/NavigationProtection/NavigationProtectionIntegrationTests.swift#L273
testGPC, XCTAssertEqual failed: ("[Integration_Tests.(unknown context at $103324c40).Results.Result(id: "top frame header", value: Optional(Integration_Tests.(unknown context at $103324c40).Results.Result.Value.string("1"))), Integration_Tests.(unknown context at $103324c40).Results.Result(id: "top frame JS API", value: Optional(Integration_Tests.(unknown context at $103324c40).Results.Result.Value.null)), Integration_Tests.(unknown context at $103324c40).Results.Result(id: "frame header", value: nil), Integration_Tests.(unknown context at $103324c40).Results.Result(id: "frame JS API", value: nil), Integration_Tests.(unknown context at $103324c40).Results.Result(id: "subequest header", value: nil)]") is not equal to ("[Integration_Tests.(unknown context at $103324c40).Results.Result(id: "top frame header", value: Optional(Integration_Tests.(unknown context at $103324c40).Results.Result.Value.string("1"))), Integration_Tests.(unknown context at $103324c40).Results.Result(id: "top frame JS API", value: Optional(Integration_Tests.(unknown context at $103324c40).Results.Result.Value.null)), Integration_Tests.(unknown context at $103324c40).Results.Result(id: "frame header", value: nil), Integration_Tests.(unknown context at $103324c40).Results.Result(id: "frame JS API", value: Optional(Integration_Tests.(unknown context at $103324c40).Results.Result.Value.bool(false))), Integration_Tests.(unknown context at $103324c40).Results.Result(id: "subequest header", value: nil)]")
|
|
Run integration tests
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
|
Build and run unit tests:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
|
Build and run unit tests:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/TCPFlowManager.swift#L194
capture of 'flow' with non-sendable type 'NEAppProxyTCPFlow?' in a `@Sendable` closure
|
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/TCPFlowManager.swift#L20
add '@preconcurrency' to suppress 'Sendable'-related warnings from module 'NetworkExtension'
|
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
|
Build and run unit tests:
LocalPackages/SubscriptionUI/Sources/SubscriptionUI/DebugMenu/DebugPurchaseView.swift#L167
extension declares a conformance of imported type 'String' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
|
Build and run unit tests:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/NetworkProtectionTokenStore+SubscriptionTokenKeychainStorage.swift#L25
extension declares a conformance of imported type 'NetworkProtectionKeychainTokenStore' to imported protocol 'SubscriptionTokenStoring'; this will not behave correctly if the owners of 'NetworkProtection' introduce this conformance in the future
|
Loading