Release notes trusted indicator changed & Close button fix for dark m…

…ode (#3041) Task/Issue URL: https://app.asana.com/0/72649045549333/1207907199406205/f https://app.asana.com/0/1148564399326804/1207905046877700/f Tech Design URL: CC: **Description**: Release notes trusted indicator changed & Close button fix for dark mode
duckduckgo · Aug 6, 2024 · 02caf5e · 02caf5e
1 parent cbe237e
commit 02caf5e
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 3 deletions.
diff --git a/DuckDuckGo/Assets.xcassets/Images/ReleaseNotesIndicator.imageset/Contents.json b/DuckDuckGo/Assets.xcassets/Images/ReleaseNotesIndicator.imageset/Contents.json
@@ -0,0 +1,12 @@
+{
+  "images" : [
+    {
+      "filename" : "Document-Color-16.pdf",
+      "idiom" : "universal"
+    }
+  ],
+  "info" : {
+    "author" : "xcode",
+    "version" : 1
+  }
+}
diff --git a/DuckDuckGo/Assets.xcassets/Images/ReleaseNotesIndicator.imageset/Document-Color-16.pdf b/DuckDuckGo/Assets.xcassets/Images/ReleaseNotesIndicator.imageset/Document-Color-16.pdf
diff --git a/DuckDuckGo/Tab/ViewModel/TabViewModel.swift b/DuckDuckGo/Tab/ViewModel/TabViewModel.swift
@@ -548,7 +548,7 @@ private extension NSAttributedString {
                                                                              title: UserText.duckPlayer)
     static let emailProtectionTrustedIndicator = trustedIndicatorAttributedString(with: .emailProtectionIcon,
                                                                                   title: UserText.emailProtectionPreferences)
-    static let releaseNotesTrustedIndicator = trustedIndicatorAttributedString(with: .duckPlayerSettings,
+    static let releaseNotesTrustedIndicator = trustedIndicatorAttributedString(with: .releaseNotesIndicator,
                                                                                title: UserText.releaseNotesTitle)
 
 }
diff --git a/DuckDuckGo/Updates/UpdateController.swift b/DuckDuckGo/Updates/UpdateController.swift
@@ -232,14 +232,14 @@ extension UpdateController: SPUUpdaterDelegate {
     func updater(_ updater: SPUUpdater, didFindValidUpdate item: SUAppcastItem) {
         os_log("Updater did find valid update: \(item.displayVersionString)(\(item.versionString))", log: .updates)
 
+        PixelKit.fire(DebugEvent(GeneralPixel.updaterDidFindUpdate))
+
         guard !areAutomaticUpdatesEnabled else {
             // If automatic updates are enabled, we are waiting until the update is downloaded
             return
         }
         // For manual updates, show the available update without downloading
         onUpdateCheckEnd(item: item, isInstalled: false)
-
-        PixelKit.fire(DebugEvent(GeneralPixel.updaterDidFindUpdate))
     }
 
     func updaterDidNotFindUpdate(_ updater: SPUUpdater, error: any Error) {

diff --git a/...s/SwiftUIExtensions/Assets.xcassets/Images/UpdateNotificationClose.imageset/Contents.json b/...s/SwiftUIExtensions/Assets.xcassets/Images/UpdateNotificationClose.imageset/Contents.json
@@ -8,5 +8,8 @@
   "info" : {
     "author" : "xcode",
     "version" : 1
+  },
+  "properties" : {
+    "template-rendering-intent" : "template"
   }
 }