Fix closing full-screen videos with the X button

duckduckgo · May 9, 2024 · a17ede4 · a17ede4
1 parent 567c062
commit a17ede4
Showing 1 changed file with 14 additions and 13 deletions.
diff --git a/DuckDuckGo/Tab/View/WebViewContainerView.swift b/DuckDuckGo/Tab/View/WebViewContainerView.swift
@@ -141,21 +141,22 @@ final class WebViewContainerView: NSView {
             }
             .store(in: &cancellables)
 
-        fullScreenWindowWillCloseCancellable = NotificationCenter.default.publisher(for: NSWindow.willCloseNotification, object: fullScreenWindow)
-            .sink { [weak self] notification in
-                self?.fullScreenWindowWillCloseCancellable = nil
-                let fullScreenWindowController = (notification.object as? NSWindow)?.windowController
-                DispatchQueue.main.async { [weak fullScreenWindowController] in
-                    guard let fullScreenWindowController else { return }
-                    // just in case.
-                    // if WKFullScreenWindowController receives `close()` the next time it‘s open it will crash because its _webView is nil
-                    // https://errors.duckduckgo.com/organizations/ddg/issues/3411/?project=6&referrer=release-issue-stream
-                    NSException.try {
-                        fullScreenWindowController.setValue(NSView(), forKeyPath: #keyPath(webView))
+        if #unavailable(macOS 14.4) {
+            fullScreenWindowWillCloseCancellable = NotificationCenter.default.publisher(for: NSWindow.willCloseNotification, object: fullScreenWindow)
+                .sink { [weak self] notification in
+                    self?.fullScreenWindowWillCloseCancellable = nil
+                    let fullScreenWindowController = (notification.object as? NSWindow)?.windowController
+                    DispatchQueue.main.async { [weak fullScreenWindowController] in
+                        guard let fullScreenWindowController else { return }
+                        // just in case.
+                        // if WKFullScreenWindowController receives `close()` the next time it‘s open it will crash because its _webView is nil
+                        // https://errors.duckduckgo.com/organizations/ddg/issues/3411/?project=6&referrer=release-issue-stream
+                        NSException.try {
+                            fullScreenWindowController.setValue(NSView(), forKeyPath: #keyPath(webView))
+                        }
                     }
-
                 }
-            }
+        }
 
     }