Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Privacy Dashboard updates #1757

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Privacy Dashboard updates #1757

merged 3 commits into from
Oct 23, 2023

Conversation

shakyShane
Copy link
Collaborator

@shakyShane shakyShane commented Oct 16, 2023 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/0/1205727958259731/f
Tech Design URL:
CC:

Description:

  • The protection toggle is added to the Breakage Form - all other functionality remains the same
  • 2 pixels were added - naming matches ios/android, but these pixels will also contain a parameter to indicate where they came from
  • see: https://app.asana.com/0/0/1205734775032446/f
image

Steps to test this PR:

  1. Run the branch
  2. Open the dashboard
  3. Click 'website not working' at the bottom
  4. Verify the protection toggles works as expected
Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@shakyShane
Copy link
Collaborator Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@shakyShane shakyShane mentioned this pull request Oct 16, 2023
Merged
6 tasks
@shakyShane shakyShane marked this pull request as ready for review October 19, 2023 14:55
@shakyShane shakyShane mentioned this pull request Oct 19, 2023
Merged
13 tasks
@shakyShane shakyShane changed the title dashboard updates from bsk Privacy Dashboard updates Oct 19, 2023
@shakyShane shakyShane requested a review from miasma13 October 19, 2023 15:05
miasma13
miasma13 approved these changes Oct 20, 2023
View reviewed changes
DuckDuckGo/Statistics/PixelEvent.swift Outdated Show resolved Hide resolved
@shakyShane shakyShane merged commit 54fec3d into develop Oct 23, 2023
18 checks passed
@shakyShane shakyShane deleted the shane/form-updates branch October 23, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miasma13 miasma13 miasma13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shakyShane @miasma13