Update Sparkle to 2.6.0 #2450
Merged
Update Sparkle to 2.6.0 #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bot: not in app board
alessandroboron
removed
the
bot: not in app board
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
|
thanks bot, I will be picking up this PR shortly :) |
ayoy
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
All works great, thanks a lot @alessandroboron! Let me merge it right away and update SPARKLE_VERSION in GitHub Actions variables so that workflows use 2.6.0 tools from now on.
|
Ah and the XPC service doesn't affect us because it's not in use as we're not using Sparkle in a sandboxed build 👍 thanks for flagging it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206873880033587/f
Description:
Update Sparkle to 2.6.0
@ayoy there’s a discussion about the Downloader XPC Service in the below url. Just making sure it won’t affect us.
sparkle-project/Sparkle#2514 (comment)
Steps to test this PR:
Scenario 1: App up to date
DuckDuckGo Privacy Browsertarget version is1.80.0and build number146.DuckDuckGo Privacy Browserscheme is selected.Main Menu->DuckDuckGo->Check for Updates…Expected Result: A popup should appear informing the user that they’re up to date.
Scenario 2: App needs update
DuckDuckGo Privacy Browsertarget build number to145. You can leave version to1.80.0.DuckDuckGo Privacy Browserscheme is selected.Main Menu->DuckDuckGo->Check for Updates…Expected Result: A popup should appear informing the user that an update is available. Make sure the update can be installed.
@ayoy you probably know if there are other scenarios to test. These are the ones I could figure out by looking at the code.
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation