macOS: Add pixels to track VPN wake and stop attempts #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
commented
Apr 24, 2024
DuckDuckGo.xcodeproj/project.pbxproj
Outdated
| @@ -1082,7 +1082,6 @@ | |||
| 4B2D06292A11C0C900DE1F49 /* Bundle+VPN.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4B4D605E2A0B29FA00BCD287 /* Bundle+VPN.swift */; }; | |||
| 4B2D062A2A11C0C900DE1F49 /* NetworkProtectionOptionKeyExtension.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4B4D605F2A0B29FA00BCD287 /* NetworkProtectionOptionKeyExtension.swift */; }; | |||
| 4B2D062C2A11C0E100DE1F49 /* Networking in Frameworks */ = {isa = PBXBuildFile; productRef = 4B2D062B2A11C0E100DE1F49 /* Networking */; }; | |||
| 4B2D062D2A11C12300DE1F49 /* Logging.swift in Sources */ = {isa = PBXBuildFile; fileRef = 85799C1725DEBB3F0007EC87 /* Logging.swift */; }; | |||
There was a problem hiding this comment.
We don't want Logging.swift in system extensions, so I removed it from our tunnel and proxy sysexes.
diegoreymendez
commented
Apr 24, 2024
| case .begin: | ||
| PixelKit.fire( | ||
| NetworkProtectionPixelEvent.networkProtectionTunnelStopAttempt, | ||
| frequency: .standard, |
There was a problem hiding this comment.
Daily attempts are useless, unfortunately.
diegoreymendez
commented
Apr 24, 2024
| // | ||
| // Ref: https://app.asana.com/0/72649045549333/1204668639086684/f | ||
| // | ||
| exit(EXIT_SUCCESS) |
There was a problem hiding this comment.
I found that after our recent changes, stopping the VPN works best when this is removed. Sometimes it was taking a while to stop with this still here.
I'll be testing this in macOS 11 on the intel mac mini shortly.
diegoreymendez
commented
Apr 24, 2024
| @@ -27,7 +27,7 @@ import PixelKit | |||
|
|
|||
| final class MacTransparentProxyProvider: TransparentProxyProvider { | |||
|
|
|||
| static var vpnProxyLogger = Logger(subsystem: OSLog.subsystem, category: "VPN Proxy") | |||
| static var vpnProxyLogger = Logger(subsystem: Bundle.main.bundleIdentifier ?? "DuckDuckGo", category: "VPN Proxy") | |||
There was a problem hiding this comment.
Just to avoid the dependency with Logging.swift.
diegoreymendez
changed the title
samsymons
approved these changes
Apr 26, 2024
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Apr 26, 2024
Task/Issue URL: https://app.asana.com/0/414235014887631/1207099030609186/f iOS PR:duckduckgo/iOS#2785 macOS PR: duckduckgo/macos-browser#2694 ## Description Adds pixels to track VPN wake and stop attempts.
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Apr 26, 2024
Task/Issue URL: https://app.asana.com/0/414235014887631/1207099030609186/f macOS PR:duckduckgo/macos-browser#2694 BSK PR: duckduckgo/BrowserServicesKit#797 ## Description Adds pixels to track VPN wake and stop attempts.
samsymons
added a commit
that referenced
this pull request
Apr 26, 2024
…utdown # By Dax the Duck (9) and others # Via GitHub (6) and others * main: (47 commits) Update BSK to 141.1.1 (#2713) macOS: VPN Metadata Improvements (#2704) duck page suggestions (#2666) macOS: Add pixels to track VPN wake and stop attempts (#2694) Trusted url indicator (#2665) remove Tab.TabContent.url (#2647) Bump version to 1.85.0 (176) Update release automation to support Privacy Pro section in release notes (#2710) Fix for VPN stop issues. (#2689) Hard-codes the VPN waitlist flags to ON (#2709) Add subscription status to the macOS metadata (#2680) Bump version to 1.85.0 (175) Call finish in the correct place (#2702) Fix layout issue on DBP (#2700) Update autoconsent to v10.6.1 (#2618) Make Clear All History shortcut available without entering Main Menu (#2682) Fix DataBrokerProtectionProcessor.swift lint Fix SwiftLint Add parameter allowed encoding to error descriptions (#2691) Remove debug flags ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1207099030609186/f
iOS PR:duckduckgo/iOS#2785
BSK PR: duckduckgo/BrowserServicesKit#797
Description
Adds pixels to track VPN wake and stop attempts.
Testing
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation