Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support expired subscription state and subscription repurchase #2707

Merged
merged 15 commits into from
May 3, 2024

Conversation

miasma13
Copy link
Contributor

@miasma13 miasma13 commented Apr 25, 2024

Task/Issue URL: https://app.asana.com/0/72649045549333/1206382263248900/f

Description:
Support expired subscription state and subscription repurchase. Repurchase is done on a platform that is matching the app distribution (independent to where it was originally bought). Changes for supporting repurchase flows are/were implemented in BSK in the following PRs:

Additional change required to support repurchase implemented in func getSubscription (called by FE to get the auth token and determine if user is authenticated) and follows decision in https://app.asana.com/0/1203936086921904/1207169529495521/f. The change is to only return the token if current subscription is not expired.

Steps to test this PR:

  1. Activate expired subscription via email
  2. Repurchase expired App Store subscription on Stripe
  3. Repurchase expired Stripe subscription on App Store
  4. Repurchase expired Stripe subscription on Stripe

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job 💪

@afterxleep afterxleep merged commit 780958d into main May 3, 2024
22 checks passed
@afterxleep afterxleep deleted the michal/expired-subs-state branch May 3, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants