enable going back to YT #2716
Closed
enable going back to YT #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakyShane
requested changes
Apr 30, 2024
There was a problem hiding this comment.
I built this branch via the github Action (linked here https://app.asana.com/0/0/1206958007597313/f) and it still has the same problem for me.
let me know if you want to go over it via zoom, as we might have our wires crossed :)
Comment on lines
+292
to
+294
| case .backForward: | ||
| // disable redirecting from YT when going back/forward | ||
| return .next |
There was a problem hiding this comment.
In your testing steps - step 5 is still failing for me.
Once I've clicked a recommended video in youtube and ended up back in duckplayer, the 'back' button now continues in a loop.
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
|
This PR has been closed after 14 days of inactivity. Feel free to reopen it if you plan to continue working on it or have further discussions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1207121069690040/f
Description:
Steps to test this PR:
set duck player to always enabled
whilst watching any video in duck player...
click 'watch in youtube'
from the youtube video page, click a recommendation from the list on the right
now you're back in duck player, try clicking the browsers 'back' button - YT should open
Set "Always ask to open duck player"
Search for a video at DDT, open on YouTube
On YT choose "Always open in duck player" - the duck player opens
Click back; Validate SERP is open.
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation