Break the Subscription module’s dependency on BSK #2721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
quanganhdo
approved these changes
May 1, 2024
# By Fernando Bunn (3) and others # Via GitHub * main: Revert "Use NotLocalizedString on DBP error screen copy" (#2731) Use NotLocalizedString on DBP error screen copy Bump version to 1.86.0 (180) Bump version to 1.86.0 (179) Update embedded files Tentative fix for tab crashes (#2727) macOS: Set Error Reporter on All SecureVault Initializations (#2717) Bump version to 1.86.0 (178) Alessandro/create subtask on pr requested (#2692) Prevent queued operations from cancelling manual scans (#2719) Fix Tab not closed for redrected download (#2715) Egress Server Failure Detection & Recovery (#2657) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
May 1, 2024
Task/Issue URL: https://app.asana.com/0/1199230911884351/1207201481522088/f iOS PR: duckduckgo/iOS#2804 macOS PR: duckduckgo/macos-browser#2721 What kind of version bump will this require?: Major Description: This PR removes the BSK dependency from the Subscription library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1207201481522088/f
Tech Design URL:
CC:
Description:
Client PR for duckduckgo/BrowserServicesKit#802.
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation