This repository has been archived by the owner on Feb 24, 2025. It is now read-only.
Adding to the Dock automatically #2722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasstrba
force-pushed
the
tom/add-to-the-dock
branch
from
b82fc44 to
8a129d4
Compare
tomasstrba
force-pushed
the
tom/add-to-the-dock
branch
from
8a129d4 to
123952e
Compare
DuckDuckGo.xcodeproj/xcshareddata/xcschemes/sandbox-test-tool.xcscheme
Outdated
Show resolved
Hide resolved
|
@SabrinaTardio , thanks for the review. I've adjusted the code based on your suggestions. It's ready for another review |
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
samsymons
added a commit
that referenced
this pull request
May 24, 2024
# By Elle Sullivan (8) and others # Via Elle Sullivan (3) and GitHub (2) * main: (26 commits) Autofill engagement KPIs for pixel reporting (#2806) autofill: don't prefix autofill email pixels with `m.mac.` (#2808) Bump BSK (#2807) Make profile selector optional (#2811) Add History to iOS (updated UI and rollout) (#2770) New autofill save & update password prompt pixels for alignment with iOS (#2801) Add mylife data broker (#2786) Increase test timeout (#2810) Subscription refactoring, BSK update (#2809) Check for entitlement in DBP agent (#2802) move permanent survey card to first position (#2804) Subscription refactoring (#2764) Bump version to 1.89.0 (191) Merge pir stabilization feature branch into main (#2789) Update age params for multiple brokers (#2800) Fix top level navigation blocks (#2792) Adding to the Dock automatically (#2722) Fix lint error Make activity only call completion once all work has actually finished Fix activity scheduler not calling completion ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1206797051025460/f
Tech Design URL:
CC:
Description:
Adding to the Dock automatically during the onboarding and through the new tab page card.
Steps to test this PR:
Preconditions
Set Safari as default browser and make sure it is part of the Dock
Make sure the DEBUG version of the application (blue icon) is not in your Dock
Run the app and turn on pixel logging messages (Debug -> Logging -> Pixel)
Test adding to the Dock during Onboarding
about:welcomem_mac_user_added_to_dock_during_onboardingwas firedTest adding to the Dock from New Tab Page
m_mac_user_added_to_dock_from_new_tab_page_cardwas firedTest adding to the Dock from Settings
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation