New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NotLocalizedString on DBP error screen copy #2732

Merged

Bunn merged 1 commit into main from bunn/dbp/localized-strings

May 2, 2024

Collaborator

Bunn commented May 1, 2024

Task/Issue URL: https://app.asana.com/0/1199230911884351/1207141364289924/f

Description:
Use NotLocalizedString on DBP error screen copy

Steps to test this PR:

Go to

macos-browser/DuckDuckGo/DBP/DataBrokerPrerequisitesStatusVerifier.swift

Line 41 in 71e3c0c

func checkStatus() -> DataBrokerPrerequisitesStatus {
Open PIR from the ... menu
Return invalidSystemPermission and check if the DBP error page correctly displays the error message
Do the same returning invalidDirectory


          Reapply "Use NotLocalizedString on DBP error screen copy" (#2731)

This reverts commit 71e3c0c.

Bunn requested a review from THISISDINOSAUR

May 1, 2024 15:20

THISISDINOSAUR approved these changes

View reviewed changes

Contributor

THISISDINOSAUR left a comment

LGTM!

Bunn merged commit a836a5c into main

23 checks passed

Bunn deleted the bunn/dbp/localized-strings branch

May 2, 2024 18:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet