Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password manager touchpoint copy updates #2734

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented May 2, 2024

Task/Issue URL: https://app.asana.com/0/72649045549333/1207044475588308/f
Tech Design URL:
CC:

Description:
Copy updates + styling change to the Save Password prompt to include the DuckDuckGo logo

Steps to test this PR:

  1. Go to fill.dev and save a password. Confirm the prompt title now has the Dax logo and updated copy "Save Password to DuckDuckGo?"
  2. Trigger an update password from fill.dev and confirm the Update prompt title also has the Dax logo and update copy "Update Password?"
  3. Confirm the system Lock Dialog copy is now "DuckDuckGo is trying to unlock your passwords and autofill info for you."
  4. Confirm the import options from the Password Management panel are "Import passwords..." / "Export passwords..."
  5. Confirm the toolbar shortcut copy is updated to "Hide Passwords Shortcut" / "Show Passwords Shortcut"
  6. Go to Settings and confirm the copy is:
  • "Import passwords..." / "Export passwords..."
  • "Open Passwords..." / "Open Identities..." / "Open Payment Methods..."
  • "Lock access to passwords and autofill info after computer is idle for" / "If not locked, anyone with access to your device will be able to use and modify your autofill info. For security purposes, payment method form fill always requires authentication."
  1. Connect to Bitwarden and regression test the Save / Update password prompts, confirming they have not been impacted

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Contributor

github-actions bot commented May 2, 2024

🚫 The Asana task linked in the PR description is not added to macOS App Board project.

  1. Verify that the correct task is linked in the PR.
    • ⚠️ Please use the actual implementation task, rather than the Code Review subtask.
  2. Verify that the task is added to macOS App Board project.
  3. When ready, remove the bot: not in app board label to retrigger the check.

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label May 2, 2024
@amddg44 amddg44 requested a review from aataraxiaa May 2, 2024 09:53
Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and verified. Logo in save dialog looks awesome! 🚀

@amddg44 amddg44 merged commit 756890e into feature/pete/make-passwords-easier-to-discover May 2, 2024
15 of 16 checks passed
@amddg44 amddg44 deleted the anya/touchpoint-copy-updates branch May 2, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants