Add temporary survey to Passwords Settings screen #2753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amddg44
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
May 9, 2024
Task/Issue URL: https://app.asana.com/0/0/1206567467430495/f iOS PR: duckduckgo/iOS#2834 macOS PR: duckduckgo/macos-browser#2753 What kind of version bump will this require?: Patch Description: Updates related to temporary survey in the clients apps passwords screens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1206567467430497/f
Tech Design URL:
CC:
Description:
Adds temporary survey to the Passwords Settings screen
Steps to test this PR:
Go to Settings > Passwords and confirm the survey prompt is visible
Tap the blue survey button and confirm the parameter
saved_passwordsis included in the URL query parameters and that the value corresponds with the bucket name for the number of passwords you have savedGo through the survey and confirm that on the question "Which, if any, of the following password managers do you currently use?", entering text for "Other" does not trigger an autofill Save Login prompt
Go back into Settings > Passwords and confirm the survey is no longer visible
Reset the prompt by going to the top menu Debug > Reset Data > Reset Passwords Survey
Leave and return to Settings > Passwords screen for the debug menu reset to take effect. The survey should now be visible again
Tap "No Thanks" to dismiss the prompt
Confirm the prompt is removed
Back out of the screen & come back in confirming the prompt does not re-appear
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation