Bunn/dbp/entitlement check test #2756
Conversation
| self.redeemUseCase = RedeemUseCase(authenticationService: authenticationService, | ||
| authenticationRepository: authenticationRepository) | ||
| self.subscriptionHandler = DataBrokerProtectionSubscriptionHandler(accountManager: AccountManager(subscriptionAppGroup: Bundle.main.appGroup(bundle: .subs))) | ||
| self.redeemUseCase = subscriptionHandler |
There was a problem hiding this comment.
The subscription handler would replace the RedeemUseCase.
This self.redeemUseCase = subscriptionHandler is here just to validate the dependency tree, but it would be removed.
| _ = ipcServiceManager | ||
| } | ||
|
|
||
| public func runOperationsAndStartSchedulerIfPossible() { | ||
| testSubscription() |
There was a problem hiding this comment.
Just test to check if the library is being accessed, obviously would be removed
| } | ||
| } | ||
|
|
||
| extension AccountManager: DataBrokerProtectionAccountManaging { |
There was a problem hiding this comment.
The idea here is to have a protocol just for DBP. Basically a wrapper to help with testing
| } | ||
| } | ||
|
|
||
| extension DataBrokerProtectionSubscriptionHandler: DataBrokerProtectionRedeemUseCase { |
| import Subscription | ||
| import Common | ||
|
|
||
| public protocol DataBrokerProtectionAccountManaging { |
There was a problem hiding this comment.
The AccountManaging protocol from BSK doesn't have the entitlement call which we'd need in the future. This protocol is just to bridge the gap between the AccountManaging protocol and the Actual AccountManager because I didn't want to send a concrete type to the DataBrokerProtectionSubscriptionHandler
| } | ||
|
|
||
| public func hasValidEntitlement() async -> Result<Bool, Error> { | ||
| SubscriptionPurchaseEnvironment.currentServiceEnvironment = settings.selectedEnvironment == .production ? .production : .staging |
There was a problem hiding this comment.
SubscriptionPurchaseEnvironment is a concrete type that doesn't have a protocol in the subscription package. I might do the same wrapper here or at least inject this dependency, this is just for test, entitlement handler will not be done in this project
Task/Issue URL:
Tech Design URL:
CC:
Description:
Steps to test this PR:
1.
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation