Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pixels to track Duck Player usage #2760

Merged
merged 9 commits into from
May 10, 2024
Merged

Add pixels to track Duck Player usage #2760

merged 9 commits into from
May 10, 2024

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented May 9, 2024

Task/Issue URL: https://app.asana.com/0/1177771139624306/1207208910013350/f

Description:
This change updates existing Duck Player pixels and adds a bunch of new pixels.

Steps to test this PR:
List of all pixels
Run the app from Xcode and verify that pixels are sent as expected:

  1. Go to Duck Player settings, verify that a pixel is sent whenever you update Duck Player mode.
  2. Set the mode to "Show option ...".
  3. Open some youtube video page (so that the overlay is shown). Verify that m_mac_duck-player_overlay_youtube_impressions is sent.
  4. Click "Watch Here". Verify that m_mac_duck-player_overlay_youtube_watch_here is sent.
  5. Reload the website. Check "Remember my choice" and click "Watch in Duck Player". Verify that m_mac_duck-player_setting_always_overlay_youtube is sent.
  6. Revert Duck Player mode to "Show option ...".
  7. Search for something and go to Videos vertical. Click on any video.
  8. Check "Remember my choice" and click "Watch in Duck Player". Verify that m_mac_duck-player_setting_always_overlay_serp is sent.
  9. Revert Duck Player mode to "Show option ...".
  10. Open any video in Duck Player. From Duck Player interface check "Always open YouTube videos in Duck Player" and wait until the checkbox disappears. Verify that m_mac_duck-player_setting_always_duck-player is fired.
  11. Throughout your testing you'll see m_mac_duck-player_daily-unique-view being logged to console on every Duck Player page load. Verify that it contains "setting" parameter describing current Duck Player mode ("always" or "default").

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@ayoy ayoy requested a review from SabrinaTardio May 9, 2024 07:38
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label May 9, 2024
@ayoy ayoy removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label May 9, 2024
Copy link
Collaborator

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM works as expected.
Just a couple of non blocking nit

DuckDuckGo/Preferences/Model/DuckPlayerPreferences.swift Outdated Show resolved Hide resolved
DuckDuckGo/YoutubePlayer/DuckPlayer.swift Outdated Show resolved Hide resolved
@ayoy ayoy merged commit 89d4dda into main May 10, 2024
20 checks passed
@ayoy ayoy deleted the dominik/duck-player-pixels branch May 10, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants