This repository has been archived by the owner on Feb 24, 2025. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1207208910013350/f
Description:
This change updates existing Duck Player pixels and adds a bunch of new pixels.
Steps to test this PR:
List of all pixels
Run the app from Xcode and verify that pixels are sent as expected:
m_mac_duck-player_overlay_youtube_impressions
is sent.m_mac_duck-player_overlay_youtube_watch_here
is sent.m_mac_duck-player_setting_always_overlay_youtube
is sent.m_mac_duck-player_setting_always_overlay_serp
is sent.m_mac_duck-player_setting_always_duck-player
is fired.m_mac_duck-player_daily-unique-view
being logged to console on every Duck Player page load. Verify that it contains "setting" parameter describing current Duck Player mode ("always" or "default").Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation