-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pixels to track Duck Player usage #2760
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er_overlay_youtube_watch_here pixels
github-actions
bot
added
the
bot: not in app board
Added by automation for pull requests with tasks not added to macOS App Board Asana project
label
May 9, 2024
ayoy
removed
the
bot: not in app board
Added by automation for pull requests with tasks not added to macOS App Board Asana project
label
May 9, 2024
SabrinaTardio
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM works as expected.
Just a couple of non blocking nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1207208910013350/f
Description:
This change updates existing Duck Player pixels and adds a bunch of new pixels.
Steps to test this PR:
List of all pixels
Run the app from Xcode and verify that pixels are sent as expected:
m_mac_duck-player_overlay_youtube_impressions
is sent.m_mac_duck-player_overlay_youtube_watch_here
is sent.m_mac_duck-player_setting_always_overlay_youtube
is sent.m_mac_duck-player_setting_always_overlay_serp
is sent.m_mac_duck-player_setting_always_duck-player
is fired.m_mac_duck-player_daily-unique-view
being logged to console on every Duck Player page load. Verify that it contains "setting" parameter describing current Duck Player mode ("always" or "default").Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation