fix(duckplayer): prevent valid video links from opening in a new tab #2796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201141132935289/1207271615212493/f
Tech Design URL:
CC:
Description:
TL;DR
This change refines the handling of certain links in the DuckPlayer. Specifically, it aims to prevent new tabs from opening when clicking on YouTube video links that would otherwise spawn a new tab.
What changed?
Before we only captured links that would open in a new tab if it was a recommendation. After testing, I think we can loosen this to cover any valid youtube link.
Steps to test this PR:
https://www.youtube.com/watch?v=Lpyl21JH6mA
BEFORE
dp1-before.mp4
AFTER
dp1-after.mp4
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation