Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(duckplayer): prevent valid video links from opening in a new tab #2796

Conversation

shakyShane
Copy link
Collaborator

@shakyShane shakyShane commented May 20, 2024


Task/Issue URL: https://app.asana.com/0/1201141132935289/1207271615212493/f
Tech Design URL:
CC:

Description:

TL;DR

This change refines the handling of certain links in the DuckPlayer. Specifically, it aims to prevent new tabs from opening when clicking on YouTube video links that would otherwise spawn a new tab.

What changed?

Before we only captured links that would open in a new tab if it was a recommendation. After testing, I think we can loosen this to cover any valid youtube link.

Steps to test this PR:

  1. ensure your duck player setting is 'always enabled'
  2. go to the following link https://www.youtube.com/watch?v=Lpyl21JH6mA
  3. ^ this is a restricted video, so click 'watch on youtube'
  4. If the PR is working, then the page should navigate to YouTube and NOT open a new tab

BEFORE

dp1-before.mp4

AFTER

dp1-after.mp4

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@shakyShane
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

@shakyShane shakyShane marked this pull request as ready for review May 20, 2024 12:13
Copy link
Contributor

🚫 The Asana task linked in the PR description is not added to macOS App Board project.

  1. Verify that the correct task is linked in the PR.
    • ⚠️ Please use the actual implementation task, rather than the Code Review subtask.
  2. Verify that the task is added to macOS App Board project.
  3. When ready, remove the bot: not in app board label to retrigger the check.

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label May 20, 2024
Copy link
Collaborator

@mallexxx mallexxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shakyShane
Copy link
Collaborator Author

Closing for now, based on the latest comment here: https://app.asana.com/0/1177771139624306/1207271615212493/f

I think we might need a different kind of fix.

@shakyShane shakyShane closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants