Privacy Pro survey support #2816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# By Federico Cappelli # Via GitHub * main: Subscription refactoring (#2764) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo/NetworkProtection/AppTargets/DeveloperIDTarget/NetworkProtectionRemoteMessaging/SurveyRemoteMessaging.swift
# By Fernando Bunn (3) and others # Via GitHub * main: Autofill engagement KPIs for pixel reporting (#2806) autofill: don't prefix autofill email pixels with `m.mac.` (#2808) Bump BSK (#2807) Make profile selector optional (#2811) Add History to iOS (updated UI and rollout) (#2770) New autofill save & update password prompt pixels for alignment with iOS (#2801) Add mylife data broker (#2786) Increase test timeout (#2810) Subscription refactoring, BSK update (#2809) Check for entitlement in DBP agent (#2802) move permanent survey card to first position (#2804) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
quanganhdo
approved these changes
May 24, 2024
* main: Update PeopleWhiz Broker Files to use hash id (#2814)
samsymons
added a commit
that referenced
this pull request
May 30, 2024
* main: (33 commits) Remove autofill survey (#2819) Bump version to 1.90.0 (192) Set marketing version to 1.90.0 Update embedded files Privacy Pro survey support (#2816) Update PeopleWhiz Broker Files to use hash id (#2814) Update BSK due to iOS changes. (#2776) Scroll address bar to caret when using arrows (#2799) Privacy Pro macOS quick follow ups (#2813) BSK bump for iOS RMF updates (#2798) Autofill engagement KPIs for pixel reporting (#2806) autofill: don't prefix autofill email pixels with `m.mac.` (#2808) Bump BSK (#2807) Make profile selector optional (#2811) Add History to iOS (updated UI and rollout) (#2770) New autofill save & update password prompt pixels for alignment with iOS (#2801) Add mylife data broker (#2786) Increase test timeout (#2810) Subscription refactoring, BSK update (#2809) Check for entitlement in DBP agent (#2802) ...
samsymons
added a commit
that referenced
this pull request
May 31, 2024
* main: Bump version to 1.90.0 (196) Revert "Add PIPAgent entitlement (#2821)" (#2823) Bump version to 1.90.0 (195) Bump version to 1.90.0 (194) Add PIPAgent entitlement (#2821) Fixes some VPN uninstallation issues (#2820) Bump version to 1.90.0 (193) Remove autofill survey (#2819) Remove autofill survey (#2819) Bump version to 1.90.0 (192) Set marketing version to 1.90.0 Update embedded files Privacy Pro survey support (#2816)
samsymons
added a commit
that referenced
this pull request
Jun 1, 2024
# By Elle Sullivan (10) and others # Via GitHub (6) and others * main: (42 commits) Update autoconsent to v10.9.0 (#2822) Bump version to 1.90.0 (196) Revert "Add PIPAgent entitlement (#2821)" (#2823) Bump version to 1.90.0 (195) Bump version to 1.90.0 (194) Add PIPAgent entitlement (#2821) Fixes some VPN uninstallation issues (#2820) Bump version to 1.90.0 (193) Remove autofill survey (#2819) Remove autofill survey (#2819) Bump version to 1.90.0 (192) Set marketing version to 1.90.0 Update embedded files Privacy Pro survey support (#2816) Update PeopleWhiz Broker Files to use hash id (#2814) Update BSK due to iOS changes. (#2776) Scroll address bar to caret when using arrows (#2799) Privacy Pro macOS quick follow ups (#2813) BSK bump for iOS RMF updates (#2798) Autofill engagement KPIs for pixel reporting (#2806) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1206971614154218/f
Tech Design URL:
CC:
Description:
This PR adds support for showing surveys to Privacy Pro users.
Steps to test this PR:
This one can be tricky to test because it requires you to have a Privacy Pro account with a certain amount of usage. I'll give instructions on that, and then instructions on how to fake that just in case:
If you have a Privacy Pro account that has been active for at least a day, and used the VPN at least one day ago, the survey will appear. If not, you can fake it with the following method:
DefaultSurveyRemoteMessaging.swifttrueInternal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation