Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes tabs shifting in Fire Window fullscreen mode #3697

Closed

Conversation

rkrenecky
Copy link

Fixes #3696

Description:

  • Fixes an issue in Fire Window fullscreen mode where tabs always left space for the "traffic lights" (minimize/close/fullscreen buttons) by changing the lower priority leading constraint to ensure tabs dynamically adjust their position and size based on the visibility of the traffic lights.
  • The issue was caused by a lower-priority constraint (StackView.Leading = Superview.Leading + 76) being applied in the Fire Window because the PinnedTabsContainerView was empty. In normal browsing mode, this constraint had no effect because the PinnedTabsContainerView contained the pinnedTabsView, and a higher-priority constraint (StackView.Leading = PinnedTabsContainerView.Trailing) took precedence.

Note: It might be sufficient to remove the lower-priority constraint altogether, but the constraint may serve as a fallback in specific scenarios I don’t know about.

Steps to test this PR:

  1. Open a Fire Window in fullscreen mode.
  2. Verify that tabs no longer leave a fixed space for the traffic lights when they are hidden.
  3. Move the cursor to the top of the screen to make the traffic lights appear.
  4. Verify that tabs shift positions to make space for the traffic lights when they appear.
  5. Compare with a regular browser window in fullscreen mode to ensure consistent behavior.

Evidence:

fire-window-fixed.mov

Copy link
Contributor

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Jan 12, 2025
Copy link
Contributor

This PR has been closed after 14 days of inactivity. Feel free to reopen it if you plan to continue working on it or have further discussions.

@github-actions github-actions bot closed this Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs always leave space for "traffic lights" in Fire Window fullscreen mode
1 participant