Fixes tabs shifting in Fire Window fullscreen mode #3697
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3696
Description:
StackView.Leading = Superview.Leading + 76
) being applied in the Fire Window because thePinnedTabsContainerView
was empty. In normal browsing mode, this constraint had no effect because thePinnedTabsContainerView
contained thepinnedTabsView
, and a higher-priority constraint (StackView.Leading = PinnedTabsContainerView.Trailing
) took precedence.Note: It might be sufficient to remove the lower-priority constraint altogether, but the constraint may serve as a fallback in specific scenarios I don’t know about.
Steps to test this PR:
Evidence:
fire-window-fixed.mov