Enable additionalCampaignParams origins #2518
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't forget to assign an individual reviewer (in addition to those already added, this should create a task for them in Asana). |
Generated file outputs:Time updated: Thu, 28 Nov 2024 08:24:10 GMT legacytrackers-unprotected-temporary.txtv3/android-config.json--- v3/android-config.json
+++ v3/android-config.json
@@ -66,8 +66,21 @@
"state": "enabled"
}
}
},
+ "additionalCampaignPixelParams": {
+ "state": "enabled",
+ "exceptions": [],
+ "settings": {
+ "origins": [
+ "funnel_pro_androidrmf_announcement_privacy",
+ "funnel_pro_androidrmf_announcement_vpn",
+ "funnel_pro_androidrmf_announcement_holiday",
+ "funnel_pro_androidrmf_announcement_wifi"
+ ]
+ },
+ "minSupportedVersion": 52100000
+ },
"aiChat": {
"state": "disabled",
"exceptions": []
},
v3/extension-brave-config.json (12 more)
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -61,8 +61,12 @@
"heuristicDetection": "enabled",
"domainDetection": "enabled"
}
},
+ "additionalCampaignPixelParams": {
+ "state": "disabled",
+ "exceptions": []
+ },
"aiChat": {
"state": "disabled",
"exceptions": []
},
latestv4/android-config.json--- v4/android-config.json
+++ v4/android-config.json
@@ -66,8 +66,21 @@
"state": "enabled"
}
}
},
+ "additionalCampaignPixelParams": {
+ "state": "enabled",
+ "exceptions": [],
+ "settings": {
+ "origins": [
+ "funnel_pro_androidrmf_announcement_privacy",
+ "funnel_pro_androidrmf_announcement_vpn",
+ "funnel_pro_androidrmf_announcement_holiday",
+ "funnel_pro_androidrmf_announcement_wifi"
+ ]
+ },
+ "minSupportedVersion": 52100000
+ },
"aiChat": {
"state": "disabled",
"exceptions": []
},
v4/extension-brave-config.json (12 more)
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -61,8 +61,12 @@
"heuristicDetection": "enabled",
"domainDetection": "enabled"
}
},
+ "additionalCampaignPixelParams": {
+ "state": "disabled",
+ "exceptions": []
+ },
"aiChat": {
"state": "disabled",
"exceptions": []
},
|
karlenDimla
force-pushed
the
android/karl/additionalpixelparams
branch
2 times, most recently
from
7f979d0
to
c4ed646
Compare
karlenDimla
force-pushed
the
android/karl/additionalpixelparams
branch
from
c4ed646
to
fc1f728
Compare
cmonfortep
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
LGTM, just one origin missing I think.
@karlenDimla if you don't have time for this, let me know, happy to update myself
|
@jonathanKingston seems your 👍 is required on this PR (I assume related to adding a new feature). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue:
https://app.asana.com/0/1204739911139421/1208850968407153/f
Description
Enables the additional params for the following campaign
Reference