don't throw an error for invalid addresses

duneanalytics · Jan 24, 2025 · 06340a6 · 06340a6
1 parent 221e9f7
commit 06340a6
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 50 deletions.
diff --git a/__tests__/hooks/useEvmTokenBalances.test.tsx b/__tests__/hooks/useEvmTokenBalances.test.tsx
@@ -31,7 +31,7 @@ describe("useTokenBalances", () => {
 
     expect(result.current).toEqual({
       data: null,
-      error: new Error("walletAddress must be a valid address"),
+      error: null,
       isLoading: false,
       nextOffset: null,
       offsets: [],
@@ -145,7 +145,7 @@ describe("useTokenBalances", () => {
     expect(mockFetchEvmBalances).not.toHaveBeenCalled();
     expect(result.current).toEqual({
       data: null,
-      error: new Error("walletAddress must be a valid address"),
+      error: null,
       isLoading: false,
       nextOffset: null,
       offsets: [],

diff --git a/__tests__/hooks/useEvmTransactions.test.tsx b/__tests__/hooks/useEvmTransactions.test.tsx
@@ -31,7 +31,7 @@ describe("useTransactions", () => {
 
     expect(result.current).toEqual({
       data: null,
-      error: new Error("walletAddress must be a valid address"),
+      error: null,
       isLoading: false,
       nextOffset: null,
       offsets: [],
@@ -217,7 +217,7 @@ describe("useTransactions", () => {
     expect(mockFetchEvmTransactions).not.toHaveBeenCalled();
     expect(result.current).toEqual({
       data: null,
-      error: new Error("walletAddress must be a valid address"),
+      error: null,
       isLoading: false,
       nextOffset: null,
       offsets: [],

diff --git a/__tests__/hooks/useSvmTokenBalances.test.tsx b/__tests__/hooks/useSvmTokenBalances.test.tsx
@@ -141,7 +141,7 @@ describe("useTokenBalances", () => {
     expect(mockFetchSvmBalances).not.toHaveBeenCalled();
     expect(svmResult.current).toEqual({
       data: null,
-      error: new Error("walletAddress must be a valid address"),
+      error: null,
       isLoading: false,
       nextOffset: null,
       offsets: [],

diff --git a/__tests__/hooks/useSvmTransactions.test.tsx b/__tests__/hooks/useSvmTransactions.test.tsx
@@ -215,7 +215,7 @@ describe("useTransactions", () => {
     expect(mockFetchSvmTransactions).not.toHaveBeenCalled();
     expect(svmResult.current).toEqual({
       data: null,
-      error: new Error("walletAddress must be a valid address"),
+      error: null,
       isLoading: false,
       nextOffset: null,
       offsets: [],

diff --git a/src/evm/useEvmTokenBalances.ts b/src/evm/useEvmTokenBalances.ts
@@ -44,17 +44,7 @@ export const useEvmTokenBalances = (
       return;
     }
 
-    if (!walletAddress || !isAddress(walletAddress)) {
-      setState({
-        data: null,
-        error: new Error("walletAddress must be a valid address"),
-        isLoading: false,
-        nextOffset: null,
-        offsets: [],
-        currentPage: 0,
-      });
-      return;
-    }
+    if (!walletAddress || !isAddress(walletAddress)) return;
 
     setState((prevState) => ({ ...prevState, isLoading: true }));
 

diff --git a/src/evm/useEvmTransactions.ts b/src/evm/useEvmTransactions.ts
@@ -44,17 +44,7 @@ export const useEvmTransactions = (
       return;
     }
 
-    if (!walletAddress || !isAddress(walletAddress)) {
-      setState({
-        data: null,
-        error: new Error("walletAddress must be a valid address"),
-        isLoading: false,
-        nextOffset: null,
-        offsets: [],
-        currentPage: 0,
-      });
-      return;
-    }
+    if (!walletAddress || !isAddress(walletAddress)) return;
 
     setState((prevState) => ({ ...prevState, isLoading: true }));
 

diff --git a/src/svm/useSvmTokenBalances.ts b/src/svm/useSvmTokenBalances.ts
@@ -43,17 +43,7 @@ export const useSvmTokenBalances = (
       return;
     }
 
-    if (!walletAddress) {
-      setState({
-        data: null,
-        error: new Error("walletAddress must be a valid address"),
-        isLoading: false,
-        nextOffset: null,
-        offsets: [],
-        currentPage: 0,
-      });
-      return;
-    }
+    if (!walletAddress) return;
 
     setState((prevState) => ({ ...prevState, isLoading: true }));
 

diff --git a/src/svm/useSvmTransactions.ts b/src/svm/useSvmTransactions.ts
@@ -43,17 +43,7 @@ export const useSvmTransactions = (
       return;
     }
 
-    if (!walletAddress) {
-      setState({
-        data: null,
-        error: new Error("walletAddress must be a valid address"),
-        isLoading: false,
-        nextOffset: null,
-        offsets: [],
-        currentPage: 0,
-      });
-      return;
-    }
+    if (!walletAddress) return;
 
     setState((prevState) => ({ ...prevState, isLoading: true }));