Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pagination to the balances hooks #14

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Add pagination to the balances hooks #14

merged 1 commit into from
Jan 23, 2025
+351 −58

Conversation

ilamanov
Copy link
Contributor

@ilamanov ilamanov commented Jan 22, 2025 •
edited
Loading

Balances endpoint doesn’t support pagination, even though it does in the API.
This PR fixes this.
Issue: https://linear.app/dune/issue/DX-738/add-pagination-to-the-balances-endpoint-in-the-hooks-repo

@ilamanov Graphite App
Copy link
Contributor Author

ilamanov commented Jan 22, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ilamanov ilamanov mentioned this pull request Jan 22, 2025
Merged
@ilamanov ilamanov marked this pull request as ready for review January 22, 2025 03:53
@ilamanov ilamanov requested review from markushauge and GarrettJMU and removed request for markushauge January 22, 2025 21:52
@ilamanov ilamanov force-pushed the 01-21-add_vitest_testing_to_the_ci_pipeline branch from fc891e1 to f19602c Compare January 23, 2025 14:46
@ilamanov ilamanov force-pushed the 01-21-add_pagination_to_the_balances_hooks branch from b8c1b74 to f402c83 Compare January 23, 2025 14:49
GarrettJMU
GarrettJMU approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@GarrettJMU GarrettJMU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm - we should prob update the readme example too

@ilamanov ilamanov mentioned this pull request Jan 23, 2025
Merged
@ilamanov
Copy link
Contributor Author

code lgtm - we should prob update the readme example too

Updated in #16

@ilamanov Graphite App
Copy link
Contributor Author

ilamanov commented Jan 23, 2025 •
edited
Loading

Merge activity

  • Jan 23, 10:24 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 23, 10:26 AM EST: Graphite rebased this pull request as part of a merge.
  • Jan 23, 10:27 AM EST: A user merged this pull request with Graphite.

@ilamanov ilamanov changed the base branch from 01-21-add_vitest_testing_to_the_ci_pipeline to graphite-base/14 January 23, 2025 15:24
@ilamanov ilamanov changed the base branch from graphite-base/14 to main January 23, 2025 15:24
@ilamanov ilamanov force-pushed the 01-21-add_pagination_to_the_balances_hooks branch from f402c83 to d4094ed Compare January 23, 2025 15:25
@ilamanov ilamanov merged commit 7f90e35 into main Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettJMU GarrettJMU GarrettJMU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilamanov @GarrettJMU