Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Safe spells for scroll #6391

Merged
merged 42 commits into from
Aug 8, 2024
Merged

Conversation

danielpartida
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


For new spell(s)

If you are building new spell(s), please provide the following information:

  • Spell name(s): schema.table_name
  • Description: [Detailed description of the new spell(s) and their purpose]
  • Who are the new spell(s) for? [Internal team or general community]
  • How will the new spell(s) be used downstream? [Description of downstream usage]
  • Implementation details: [Information on how the spell(s) are implemented]
  • Test instructions: [How to test the new spell(s)]
  • Related issue(s): [Link to related issues, if any]

For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

  • Description: [Description of the changes made]

For bug fixes

If you are fixing a bug, please provide the following information:

  • Description: [Description of the bug fix]
  • Steps to reproduce: [How to reproduce the bug]
  • Implementation details: [Information on how the bug was fixed]
  • Test instructions: [How to test the fix]
  • Related issue(s): [Link to related issues, if any]

Additional information

Please provide any additional information that might help us review your pull request:

  • [Any additional information]

Thank you for your contribution!

danielpartida and others added 18 commits February 20, 2024 09:02
L1 singleton 0x41675C099F32341bf84BFc5382aF534df5C7461a
L2 singleton 0x29fcB43b46531BcA003ddC8FCB67FFE91900C76
Models updated are:
- safe_native_transfers.all.sql -> Added safe_zkevm_matic_transfers
- safe_safes_all.sql -> Added safe_zkevm_safes
- safe_transactions_all.sql -> safe_zkevm_transactions
# Conflicts:
#	models/safe/zkevm/safe_zkevm_matic_transfers.sql
#	models/safe/zkevm/safe_zkevm_safes.sql
#	models/safe/zkevm/safe_zkevm_schema.yml
#	models/safe/zkevm/safe_zkevm_singletons.sql
@dune-eng
Copy link

Workflow run id 10005090226 approved.

@dune-eng
Copy link

Workflow run id 10005090545 approved.

@jeff-dude jeff-dude added the WIP work in progress label Jul 19, 2024
@dune-eng
Copy link

Workflow run id 10178665842 approved.

@dune-eng
Copy link

Workflow run id 10178666339 approved.

@dune-eng
Copy link

Workflow run id 10178719610 approved.

@dune-eng
Copy link

Workflow run id 10178719879 approved.

@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR and removed WIP work in progress labels Aug 6, 2024
@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Aug 6, 2024
@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10282237922 approved.

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10282238184 approved.

danielpartida and others added 3 commits August 7, 2024 22:41
# Conflicts:
#	dbt_subprojects/hourly_spellbook/models/_project/safe/safe_native_transfers_all.sql
#	dbt_subprojects/hourly_spellbook/models/_project/safe/safe_safes_all.sql
#	dbt_subprojects/hourly_spellbook/models/_project/safe/safe_transactions_all.sql
@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10291510789 approved.

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10291511096 approved.

@danielpartida
Copy link
Contributor Author

Merge conflicted fixed @jeff-dude

danielpartida and others added 4 commits August 8, 2024 09:07
# Conflicts:
#	dbt_subprojects/hourly_spellbook/models/_project/safe/safe_native_transfers_all.sql
#	dbt_subprojects/hourly_spellbook/models/_project/safe/safe_safes_all.sql
#	dbt_subprojects/hourly_spellbook/models/_project/safe/safe_schema.yml
#	dbt_subprojects/hourly_spellbook/models/_project/safe/safe_transactions_all.sql
@dune-eng
Copy link

dune-eng commented Aug 8, 2024

Workflow run id 10297628433 approved.

@dune-eng
Copy link

dune-eng commented Aug 8, 2024

Workflow run id 10297628613 approved.

@danielpartida danielpartida requested a review from jeff-dude August 8, 2024 07:14
@danielpartida
Copy link
Contributor Author

Merge conflicts resolved once again @jeff-dude

@jeff-dude jeff-dude removed the blocked label Aug 8, 2024
@jeff-dude jeff-dude merged commit 88fe12c into duneanalytics:main Aug 8, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2024
@danielpartida danielpartida deleted the add-safes-on-scroll branch September 19, 2024 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants