Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add safes models on blast #6472

Merged
merged 44 commits into from
Aug 7, 2024
Merged

Conversation

danielpartida
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Update!

Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


For new spell(s)

If you are building new spell(s), please provide the following information:

  • Spell name(s): schema.table_name
  • Description: [Detailed description of the new spell(s) and their purpose]
  • Who are the new spell(s) for? [Internal team or general community]
  • How will the new spell(s) be used downstream? [Description of downstream usage]
  • Implementation details: [Information on how the spell(s) are implemented]
  • Test instructions: [How to test the new spell(s)]
  • Related issue(s): [Link to related issues, if any]

For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

  • Description: [Description of the changes made]

For bug fixes

If you are fixing a bug, please provide the following information:

  • Description: [Description of the bug fix]
  • Steps to reproduce: [How to reproduce the bug]
  • Implementation details: [Information on how the bug was fixed]
  • Test instructions: [How to test the fix]
  • Related issue(s): [Link to related issues, if any]

Additional information

Please provide any additional information that might help us review your pull request:

  • [Any additional information]

Thank you for your contribution!

danielpartida and others added 24 commits February 20, 2024 09:02
L1 singleton 0x41675C099F32341bf84BFc5382aF534df5C7461a
L2 singleton 0x29fcB43b46531BcA003ddC8FCB67FFE91900C76
Models updated are:
- safe_native_transfers.all.sql -> Added safe_zkevm_matic_transfers
- safe_safes_all.sql -> Added safe_zkevm_safes
- safe_transactions_all.sql -> safe_zkevm_transactions
# Conflicts:
#	models/safe/zkevm/safe_zkevm_matic_transfers.sql
#	models/safe/zkevm/safe_zkevm_safes.sql
#	models/safe/zkevm/safe_zkevm_schema.yml
#	models/safe/zkevm/safe_zkevm_singletons.sql
Crosschain spells include
- Native transfers
- Safes deployed
- Safe transactions
@dune-eng
Copy link

Workflow run id 10178797101 approved.

@dune-eng
Copy link

Workflow run id 10178797448 approved.

@dune-eng
Copy link

Workflow run id 10178881665 approved.

@dune-eng
Copy link

Workflow run id 10178882030 approved.

@jeff-dude jeff-dude added the ready-for-review this PR development is complete, please review label Jul 31, 2024
@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10282216461 approved.

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10282216720 approved.

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10282308700 approved.

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10282309421 approved.

@danielpartida
Copy link
Contributor Author

Thank you for the comments @jeff-dude, just included them to the Safe Blast models

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10282598537 approved.

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10282599056 approved.

@jeff-dude jeff-dude self-assigned this Aug 7, 2024
@jeff-dude jeff-dude added ready-for-merging and removed WIP work in progress labels Aug 7, 2024
@jeff-dude
Copy link
Member

i don't have access to your branch to resolve merge conflicts. plz help push when you can. this will happen again on scroll PR when merging this one.

danielpartida and others added 3 commits August 7, 2024 22:41
# Conflicts:
#	dbt_subprojects/hourly_spellbook/models/_project/safe/safe_native_transfers_all.sql
#	dbt_subprojects/hourly_spellbook/models/_project/safe/safe_safes_all.sql
#	dbt_subprojects/hourly_spellbook/models/_project/safe/safe_transactions_all.sql
@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10291485689 approved.

@dune-eng
Copy link

dune-eng commented Aug 7, 2024

Workflow run id 10291486051 approved.

@jeff-dude jeff-dude removed the blocked label Aug 7, 2024
@jeff-dude jeff-dude merged commit 8255eb4 into duneanalytics:main Aug 7, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2024
@danielpartida danielpartida deleted the add-safes-on-blast branch September 19, 2024 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants