add sanctum router to solana dex trades

[senyor-kodi]

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

Add Sanctum Router to dex_solana.trades

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[senyor-kodi]

I have read the CLA Document and I hereby sign the CLA

[jeff-dude]

welcome to spellbook!

you are correct, the issue here is memory related and cluster crashing. this is not uncommon for solana data 🥲

my recommendation for dev and testing phase is to hardcode a short timeframe filter to reduce data volume heavily. rule of thumb: any time you add an incremental filter, that's a good indication to add hardcoded filter outside for historical run for last ~few weeks or so. that should help get CI running end-to-end

[senyor-kodi]

Hey jeff, adding a time filter for last week did it!

Had to fix a couple typos before all checks passed but seems to be good now. Do I need to do anything else on my end? Should I keep the time filter?

[jeff-dude]

Hey jeff, adding a time filter for last week did it!

Had to fix a couple typos before all checks passed but seems to be good now. Do I need to do anything else on my end? Should I keep the time filter?

if you haven't already, i would recommend querying the CI tables directly on the app and test the data output to ensure it meets your expectations (even though its subset of history). if you click into the gh action logs and expand the dbt model run step, you can find table names and query them directly 🙏

once you are comfortable with the output, we can revert the hardcoded date commit and prep for merge

[senyor-kodi]

if you haven't already, i would recommend querying the CI tables directly on the app and test the data output to ensure it meets your expectations (even though its subset of history). if you click into the gh action logs and expand the dbt model run step, you can find table names and query them directly 🙏

once you are comfortable with the output, we can revert the hardcoded date commit and prep for merge

the tables for the two incremental models look fine!

however the view model test_schema.git_dunesql_e513efa_sanctum_router_trades comes up empty. is this normal or should I be getting a result here as well?

[jeff-dude]

however the view model test_schema.git_dunesql_e513efa_sanctum_router_trades comes up empty. is this normal or should I be getting a result here as well?

good catch, another reason to test these output tables!

in this scenario, i believe we are actually all good. dex_solana_trades model isn't modified in this PR, since you only need to add to *_base_trades. CI will redirect to read from prod for any models that aren't in the PR itself. this means the view is reading from prod table, where we know this data isn't integrated yet.

we can confirm that the _base_trades table has rows as expected:

select *
from test_schema.git_dunesql_e513efa_dex_solana_base_trades --test_schema.git_dunesql_e513efa_sanctum_router_trades
where project = 'sanctum_router' and version = 1
limit 10

this will be all good in prod.

let me give the PR a more general review prior to you reverting the hardcoded date filter for historical data.

[jeff-dude]

this is looking clean to me 🙏
feel free to revert the short timeframe and we can prep for merge

[senyor-kodi]

Done! Thanks a lot for your help @jeff-dude and thank you for all the work y'all do on Spellbook 🙏🙏

[jeff-dude]

Done! Thanks a lot for your help @jeff-dude and thank you for all the work y'all do on Spellbook 🙏🙏

happy to help, thank you for contributing with us 🤝

[gitpoap-bot]

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Dune Contributor:

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.