[fluid] adding fluid to dex.trades #7291
Conversation
|
@jeff-dude need some help with debugging this |
dbt_subprojects/dex/models/trades/ethereum/platforms/fluid_ethereum_base_trades.sql
Outdated
Show resolved
Hide resolved
| from {{ source('ethereum', 'logs')}} | ||
| where topic0 = 0x3fecd5f7aca6136a20a999e7d11ff5dcea4bd675cb125f93ccd7d53f98ec57e4 | ||
| -- DexT1Deployed -> sample tx: https://etherscan.io/tx/0xabf5c0e676e69de941c283400d7ac5f47b17a09d870f225b5240522f95da501c#eventlog |
There was a problem hiding this comment.
any particular reason we're not going through normal decoding process here, to build those tables vs. reading raw data?
There was a problem hiding this comment.
the etherscan abi didn't have that particular event.
i can manually edit the json to add that single event in.
I'm not sure if its safe though.
https://etherscan.io/address/0x91716C4EDA1Fb55e84Bf8b4c7085f84285c19085#code
There was a problem hiding this comment.
i see a warning there that the contract may be a proxy? doesn't that typically mean you can find the underlying contract, and that has the correct ABI (or am i oversimplifying that)?
There was a problem hiding this comment.
cant really say its the correct ABI, since the events are split between both proxy and impl.
i think the ideal work around is to manually add the event to the abi json. i however suspect, with their v2 launch this could change.
There was a problem hiding this comment.
on the otherhand, i think i should add version to the tables
There was a problem hiding this comment.
yeah, we should have a model per version of the DEX to keep logic isolated and understand the differences. are you planning to do that in this PR?
if this doesn't fix the existing version logic, and we need to use raw logs due to decoding complexities, we can likely sign off on that.
There was a problem hiding this comment.
oh i see, you added version already, but v2 doesn't exist yet?
There was a problem hiding this comment.
i saw it making waves on twitter today. will need to spend some time to figure out whats up with that.
There was a problem hiding this comment.
okay, do you want to keep this PR open to wait for that?
There was a problem hiding this comment.
i shall add that in a later PR
jeff-dude
added
question
dbt_subprojects/dex/models/trades/ethereum/platforms/fluid_v1_ethereum_base_trades.sql
Outdated
Show resolved
Hide resolved
jeff-dude
added
WIP
…ethereum_base_trades.sql Co-authored-by: jeff-dude <[email protected]>
jeff-dude
added
ready-for-merging
and removed
WIP
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
[...]
quick links for more information: