Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mavis Market to nft.trades #7355

Merged
merged 31 commits into from
Dec 30, 2024
Merged

Conversation

peterrliem
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

[...]


quick links for more information:

@github-actions github-actions bot marked this pull request as draft December 19, 2024 08:10
@github-actions github-actions bot added WIP work in progress dbt: nft covers the NFT dbt subproject labels Dec 19, 2024
@0xRobin 0xRobin self-assigned this Dec 20, 2024
@Murshadddd
Copy link

#7234

@0xRobin 0xRobin marked this pull request as ready for review December 23, 2024 10:26
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Dec 23, 2024
Copy link
Collaborator

@0xRobin 0xRobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some questions/comments around data QA.
It would also be nice to add a seed test to the model.
You can see how that is done for collectionswap here:
seed: https://github.com/duneanalytics/spellbook/blob/main/dbt_subprojects/nft/seeds/trades/base_trades/collectionswap_ethereum_base_trades_seed.csv
schema:

- name: collectionswap_ethereum_base_trades_seed
config:
column_types:
tx_hash: varbinary
buyer: varbinary
seller: varbinary
nft_contract_address: varbinary
price_raw: uint256
platform_fee_amount_raw: uint256
royalty_fee_amount_raw: uint256
nft_token_id: uint256

test:
- check_seed:
seed_file: ref('collectionswap_ethereum_base_trades_seed')
match_columns:
- block_number
- tx_hash
- sub_tx_trade_id
check_columns:
- buyer
- seller
- nft_contract_address
- nft_token_id
- price_raw
- platform_fee_amount_raw
- royalty_fee_amount_raw

Made changes based on Rob's suggestions. Thanks Rob!
@0xRobin 0xRobin added ready-for-merging and removed ready-for-review this PR development is complete, please review labels Dec 27, 2024
@0xRobin 0xRobin merged commit 6ab44e7 into duneanalytics:main Dec 30, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: nft covers the NFT dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants