Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add balancer_cowswap_amm spells on Base (DEX) #7357

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

viniabussafi
Copy link
Contributor

@viniabussafi viniabussafi commented Dec 19, 2024

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

This PR simply replicates the balancer_cowswap_amm spells we have for Base


quick links for more information:

@github-actions github-actions bot added WIP work in progress dbt: dex covers the DEX dbt subproject labels Dec 19, 2024
@viniabussafi viniabussafi marked this pull request as ready for review December 19, 2024 09:49
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Dec 19, 2024
@Hosuke Hosuke self-assigned this Dec 19, 2024
Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @viniabussafi

Sample balancer_cowswap_amm_base_trades

Though this view currently has 0 rows, due to 0 rows in test_schema.git_dunesql_efff68b_labels_balancer_cowswap_amm_pools_base.

@Hosuke Hosuke added in review Assignee is currently reviewing the PR ready-for-merging and removed ready-for-review this PR development is complete, please review in review Assignee is currently reviewing the PR labels Dec 19, 2024
@0xRobin 0xRobin merged commit 8843bf1 into duneanalytics:main Dec 20, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants